danvics/rdt-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use ISynologyClient (mockable) and inject IDelayProvider so SynologyTorrentClient is testable

Browse source
This commit is contained in:
Cucumberrbob 2025-02-17 22:00:19 +00:00
parent c546bd0173
commit 2bbbf0fd10
No known key found for this signature in database
GPG key ID: 2B935C47401C3614
2 changed files with 22 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
server/RdtClient.Service/Helpers/IDelayProvider.cs Normal file
View file

@ -0,0 +1,6 @@
namespace RdtClient.Service.Helpers;
public interface IDelayProvider
{
public Task Delay(Int32 milliseconds);
}

21
server/RdtClient.Service/Services/Downloaders/DownloadStationDownloader.cs
View file

@ -1,9 +1,18 @@
using Serilog; using RdtClient.Service.Helpers;
using Serilog;
using Synology.Api.Client; using Synology.Api.Client;
using Synology.Api.Client.Apis.DownloadStation.Task.Models; using Synology.Api.Client.Apis.DownloadStation.Task.Models;
namespace RdtClient.Service.Services.Downloaders; namespace RdtClient.Service.Services.Downloaders;
class DelayProvider : IDelayProvider
{
public Task Delay(Int32 delay)
{
return Task.Delay(delay);
}
}
public class DownloadStationDownloader : IDownloader public class DownloadStationDownloader : IDownloader
{ {
public event EventHandler<DownloadCompleteEventArgs>? DownloadComplete; public event EventHandler<DownloadCompleteEventArgs>? DownloadComplete;
@ -11,16 +20,17 @@ public class DownloadStationDownloader : IDownloader
private const Int32 RetryCount = 5; private const Int32 RetryCount = 5;
private readonly SynologyClient _synologyClient; private readonly ISynologyClient _synologyClient;
private readonly ILogger _logger; private readonly ILogger _logger;
private readonly String _filePath; private readonly String _filePath;
private readonly String _uri; private readonly String _uri;
private readonly String? _remotePath; private readonly String? _remotePath;
private readonly IDelayProvider _delayProvider;
private String? _gid; private String? _gid;
private DownloadStationDownloader(String? gid, String uri, String? remotePath, String filePath, String downloadPath, SynologyClient synologyClient) public DownloadStationDownloader(String? gid, String uri, String? remotePath, String filePath, String downloadPath, ISynologyClient synologyClient, IDelayProvider? delayProvider = null)
{ {
_logger = Log.ForContext<DownloadStationDownloader>(); _logger = Log.ForContext<DownloadStationDownloader>();
_logger.Debug($"Instantiated new DownloadStation Downloader for URI {uri} to filePath {filePath} and downloadPath {downloadPath} and GID {gid}"); _logger.Debug($"Instantiated new DownloadStation Downloader for URI {uri} to filePath {filePath} and downloadPath {downloadPath} and GID {gid}");
@ -30,6 +40,7 @@ public class DownloadStationDownloader : IDownloader
_uri = uri; _uri = uri;
_remotePath = remotePath; _remotePath = remotePath;
_synologyClient = synologyClient; _synologyClient = synologyClient;
_delayProvider = delayProvider ?? new DelayProvider();
} }
public static async Task<DownloadStationDownloader> Init(String? gid, String uri, String filePath, String downloadPath, String? category) public static async Task<DownloadStationDownloader> Init(String? gid, String uri, String filePath, String downloadPath, String? category)
@ -149,13 +160,13 @@ public class DownloadStationDownloader : IDownloader
retryCount++; retryCount++;
_logger.Error($"Task not found in DownloadStation after creat Sucess. Retrying {retryCount}/{RetryCount}"); _logger.Error($"Task not found in DownloadStation after creat Sucess. Retrying {retryCount}/{RetryCount}");
await Task.Delay(retryCount * 1000); await _delayProvider.Delay(retryCount * 1000);
} }
catch (Exception e) catch (Exception e)
{ {
retryCount++; retryCount++;
_logger.Error($"Error starting download: {e.Message}. Retrying {retryCount}/{RetryCount}"); _logger.Error($"Error starting download: {e.Message}. Retrying {retryCount}/{RetryCount}");
await Task.Delay(retryCount * 1000); await _delayProvider.Delay(retryCount * 1000);
} }
} }