From 9a5b045378ae8b04498c20fd01f3cb1e292bf234 Mon Sep 17 00:00:00 2001 From: Arvid Norlander Date: Wed, 5 Aug 2020 18:25:51 +0200 Subject: [PATCH] Get rid of star imports. These are dangerous as you will import not only the functions defined in the other module but also all of it's imports! This makes automated cleanups brittle. --- bin/validity-led-dance | 4 +++- validitysensor/tls.py | 2 +- validitysensor/usb.py | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/bin/validity-led-dance b/bin/validity-led-dance index 48e12cc..2e67a2b 100755 --- a/bin/validity-led-dance +++ b/bin/validity-led-dance @@ -5,7 +5,9 @@ import os from binascii import unhexlify from enum import Enum from validitysensor.flash import read_flash -from validitysensor.sensor import * +from validitysensor.sensor import glow_start_scan, glow_end_scan +from validitysensor.util import assert_status +from validitysensor.tls import tls from validitysensor import init from time import sleep from usb import core as usb_core diff --git a/validitysensor/tls.py b/validitysensor/tls.py index dc9cdcf..7be4ff5 100644 --- a/validitysensor/tls.py +++ b/validitysensor/tls.py @@ -3,7 +3,7 @@ import os import pickle import logging from struct import pack, unpack -from binascii import * +from binascii import hexlify, unhexlify from cryptography.hazmat.primitives.ciphers import Cipher, algorithms, modes from cryptography.hazmat.backends import default_backend diff --git a/validitysensor/usb.py b/validitysensor/usb.py index fd7c2f2..6b80bc9 100644 --- a/validitysensor/usb.py +++ b/validitysensor/usb.py @@ -1,7 +1,7 @@ import logging import errno import usb.core as ucore -from binascii import * +from binascii import hexlify, unhexlify from .util import assert_status from struct import unpack from usb.core import USBError