danvics/postmoogle
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use just Error, not Warn + Error

Browse source 
The downside of this is that the raw error gets reported to the user
in the room, instead of just being logged.
This commit is contained in:
Slavi Pantaleev 2022-08-23 17:45:15 +03:00
parent 726bc95c26
commit 55a76c5c6b
2 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
bot/mailbox.go
View file

@ -49,8 +49,7 @@ func (b *Bot) getMailbox(ctx context.Context, evt *event.Event) {
cfg, err := b.getSettings(span.Context(), evt.RoomID)
if err != nil {
b.log.Warn("cannot get %s settings: %v", evt.RoomID, err)
b.Error(span.Context(), evt.RoomID, "failed to retrieve settings")
b.Error(span.Context(), evt.RoomID, "failed to retrieve setting: %v", err)
return
}
@ -83,8 +82,7 @@ func (b *Bot) setMailbox(ctx context.Context, evt *event.Event, mailbox string)
}
cfg, err := b.getSettings(span.Context(), evt.RoomID)
if err != nil {
b.log.Warn("cannot get settings: %v", err)
b.Error(span.Context(), evt.RoomID, "failed to retrieve settings")
b.Error(span.Context(), evt.RoomID, "failed to retrieve setting: %v", err)
return
}

6
bot/owner.go
View file

@ -23,8 +23,7 @@ func (b *Bot) getOwner(ctx context.Context, evt *event.Event) {
cfg, err := b.getSettings(span.Context(), evt.RoomID)
if err != nil {
b.log.Warn("cannot get settings: %v", err)
b.Error(span.Context(), evt.RoomID, "failed to retrieve settings")
b.Error(span.Context(), evt.RoomID, "failed to retrieve setting: %v", err)
return
}
@ -48,8 +47,7 @@ func (b *Bot) setOwner(ctx context.Context, evt *event.Event, owner string) {
ownerID := id.UserID(owner)
cfg, err := b.getSettings(span.Context(), evt.RoomID)
if err != nil {
b.log.Warn("cannot get settings: %v", err)
b.Error(span.Context(), evt.RoomID, "failed to retrieve settings")
b.Error(span.Context(), evt.RoomID, "failed to retrieve setting: %v", err)
return
}