From f7e2c03edc3db777a021f54a5c81ab8a62ccf138 Mon Sep 17 00:00:00 2001 From: Kieran Eglin Date: Tue, 16 Jul 2024 15:04:36 -0700 Subject: [PATCH] Tests --- .../metadata/metadata_file_helpers_test.exs | 29 +++++++++++--- test/pinchflat/metadata/nfo_builder_test.exs | 39 ++++++++++++++++++- 2 files changed, 61 insertions(+), 7 deletions(-) diff --git a/test/pinchflat/metadata/metadata_file_helpers_test.exs b/test/pinchflat/metadata/metadata_file_helpers_test.exs index 36db3cd..b1b8b2b 100644 --- a/test/pinchflat/metadata/metadata_file_helpers_test.exs +++ b/test/pinchflat/metadata/metadata_file_helpers_test.exs @@ -11,6 +11,16 @@ defmodule Pinchflat.Metadata.MetadataFileHelpersTest do {:ok, %{media_item: media_item}} end + describe "metadata_directory_for/1" do + test "returns the metadata directory for the given record", %{media_item: media_item} do + base_metadata_directory = Application.get_env(:pinchflat, :metadata_directory) + + metadata_directory = Helpers.metadata_directory_for(media_item) + + assert metadata_directory == Path.join([base_metadata_directory, "media_items", "#{media_item.id}"]) + end + end + describe "compress_and_store_metadata_for/2" do test "returns the filepath", %{media_item: media_item} do metadata_map = %{"foo" => "bar"} @@ -142,13 +152,20 @@ defmodule Pinchflat.Metadata.MetadataFileHelpersTest do end end - describe "metadata_directory_for/1" do - test "returns the metadata directory for the given record", %{media_item: media_item} do - base_metadata_directory = Application.get_env(:pinchflat, :metadata_directory) + describe "season_and_episode_from_media_filepath/1" do + test "returns a season and episode if one can be determined" do + assert {:ok, {"1", "2"}} = Helpers.season_and_episode_from_media_filepath("/foo/s1e2 - test.mp4") + assert {:ok, {"1", "2"}} = Helpers.season_and_episode_from_media_filepath("/foo/S1E2 - test.mp4") + assert {:ok, {"001", "002"}} = Helpers.season_and_episode_from_media_filepath("/foo/s001e002 - test.mp4") + assert {:ok, {"1", "2"}} = Helpers.season_and_episode_from_media_filepath("/foo/s1e2bar - test.mp4") + assert {:ok, {"1", "2"}} = Helpers.season_and_episode_from_media_filepath("/foo/bar s1e2 - test.mp4") + end - metadata_directory = Helpers.metadata_directory_for(media_item) - - assert metadata_directory == Path.join([base_metadata_directory, "media_items", "#{media_item.id}"]) + test "returns an error if a season and episode can't be determined" do + assert {:error, :indeterminable} = Helpers.season_and_episode_from_media_filepath("/foo/test.mp4") + assert {:error, :indeterminable} = Helpers.season_and_episode_from_media_filepath("/foo/s1 - test.mp4") + assert {:error, :indeterminable} = Helpers.season_and_episode_from_media_filepath("/foo/s1e - test.mp4") + assert {:error, :indeterminable} = Helpers.season_and_episode_from_media_filepath("/foo/s1etest.mp4") end end end diff --git a/test/pinchflat/metadata/nfo_builder_test.exs b/test/pinchflat/metadata/nfo_builder_test.exs index c8b032a..47217c7 100644 --- a/test/pinchflat/metadata/nfo_builder_test.exs +++ b/test/pinchflat/metadata/nfo_builder_test.exs @@ -5,7 +5,7 @@ defmodule Pinchflat.Metadata.NfoBuilderTest do alias Pinchflat.Utils.FilesystemUtils setup do - filepath = FilesystemUtils.generate_metadata_tmpfile(:json) + filepath = FilesystemUtils.generate_metadata_tmpfile(:nfo) on_exit(fn -> File.rm!(filepath) end) @@ -45,6 +45,43 @@ defmodule Pinchflat.Metadata.NfoBuilderTest do assert String.contains?(nfo, "hello' & <world>") end + + test "uses the season and episode number from the filepath if it can be determined" do + metadata = %{ + "title" => "title", + "uploader" => "uploader", + "id" => "id", + "description" => "description", + "upload_date" => "20210101" + } + + tmpfile_directory = Application.get_env(:pinchflat, :tmpfile_directory) + filepath = Path.join([tmpfile_directory, "foo/s0123e456.nfo"]) + + result = NfoBuilder.build_and_store_for_media_item(filepath, metadata) + nfo = File.read!(result) + + assert String.contains?(nfo, "0123") + assert String.contains?(nfo, "456") + + File.rm!(filepath) + end + + test "uses the upload date if the season and episode number can't be determined", %{filepath: filepath} do + metadata = %{ + "title" => "title", + "uploader" => "uploader", + "id" => "id", + "description" => "description", + "upload_date" => "20210101" + } + + result = NfoBuilder.build_and_store_for_media_item(filepath, metadata) + nfo = File.read!(result) + + assert String.contains?(nfo, "2021") + assert String.contains?(nfo, "0101") + end end describe "build_and_store_for_source/2" do