danvics/pinchflat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Updated TODO

Browse source
This commit is contained in:
Kieran Eglin 2025-01-02 15:19:02 -08:00
parent 9590fd1a98
commit f67d31dbd7
No known key found for this signature in database
GPG key ID: 193984967FCF432D
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/pinchflat/yt_dlp/command_runner.ex
View file

@ -39,9 +39,12 @@ defmodule Pinchflat.YtDlp.CommandRunner do
formatted_command_opts = [url] ++ CliUtils.parse_options(all_opts) formatted_command_opts = [url] ++ CliUtils.parse_options(all_opts)
case CliUtils.wrap_cmd(command, formatted_command_opts, stderr_to_stdout: true) do case CliUtils.wrap_cmd(command, formatted_command_opts, stderr_to_stdout: true) do
# TODO: confirm that 101 is unique to these cases # yt-dlp exit codes:
# 0 is normal exit, 101 is an intentional exit due to some # 0 = Everything is successful
# break condition (like --break-on-existing) # 100 = yt-dlp must restart for update to complete
# 101 = Download cancelled by --max-downloads etc
# 2 = Error in user-provided options
# 1 = Any other error
{_, status} when status in [0, 101] -> {_, status} when status in [0, 101] ->
# IDEA: consider deleting the file after reading it. It's in the tmp dir, so it's not # IDEA: consider deleting the file after reading it. It's in the tmp dir, so it's not
# a huge deal, but it's still a good idea to clean up after ourselves. # a huge deal, but it's still a good idea to clean up after ourselves.