From f13122b36e29a10683ddb06dab5b29768c05b30c Mon Sep 17 00:00:00 2001
From: Kieran Eglin <kieran.eglin@gmail.com>
Date: Wed, 8 May 2024 09:44:02 -0700
Subject: [PATCH] More flakey tests

---
 .../components/layouts/partials/sidebar.html.heex          | 4 +++-
 .../lifecycle/user_scripts/command_runner_test.exs         | 7 ++++---
 .../controllers/media_profile_controller_test.exs          | 2 +-
 test/support/data_case.ex                                  | 3 +++
 test/support/testing_helper_methods.ex                     | 7 +++++++
 5 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/lib/pinchflat_web/components/layouts/partials/sidebar.html.heex b/lib/pinchflat_web/components/layouts/partials/sidebar.html.heex
index 11e778c..292e803 100644
--- a/lib/pinchflat_web/components/layouts/partials/sidebar.html.heex
+++ b/lib/pinchflat_web/components/layouts/partials/sidebar.html.heex
@@ -18,7 +18,9 @@
     </div>
     <div class="no-scrollbar flex flex-col overflow-y-auto duration-300 ease-linear">
       <nav class="mt-3 px-4 py-4 lg:px-6">
-        <h3 class="mb-4 ml-4 text-sm font-medium text-bodydark2">MENU</h3>
+        <h3 class="mb-4 ml-4 text-sm font-medium text-bodydark2">
+          <span>MENU</span>
+        </h3>
         <div class="flex flex-col justify-between">
           <ul class="mb-6 flex flex-col gap-1.5">
             <.sidebar_item icon="hero-home" text="Home" href={~p"/"} />
diff --git a/test/pinchflat/lifecycle/user_scripts/command_runner_test.exs b/test/pinchflat/lifecycle/user_scripts/command_runner_test.exs
index 51945f1..351f4c4 100644
--- a/test/pinchflat/lifecycle/user_scripts/command_runner_test.exs
+++ b/test/pinchflat/lifecycle/user_scripts/command_runner_test.exs
@@ -15,11 +15,12 @@ defmodule Pinchflat.Lifecycle.UserScripts.CommandRunnerTest do
     test "runs the provided lifecycle file if present" do
       # We *love* indirectly testing side effects
       tmp_dir = Application.get_env(:pinchflat, :tmpfile_directory)
-      File.write(filepath(), "#!/bin/bash\ntouch #{tmp_dir}/test_file\n")
+      filename = "#{tmp_dir}/test_file-#{Enum.random(1..1000)}"
+      File.write(filepath(), "#!/bin/bash\ntouch #{filename}\n")
 
-      refute File.exists?("#{tmp_dir}/test_file")
+      refute File.exists?(filename)
       assert :ok = Runner.run(:media_downloaded, %{})
-      assert File.exists?("#{tmp_dir}/test_file")
+      assert File.exists?(filename)
     end
 
     test "passes the event name to the script" do
diff --git a/test/pinchflat_web/controllers/media_profile_controller_test.exs b/test/pinchflat_web/controllers/media_profile_controller_test.exs
index 37fcaf6..40879f3 100644
--- a/test/pinchflat_web/controllers/media_profile_controller_test.exs
+++ b/test/pinchflat_web/controllers/media_profile_controller_test.exs
@@ -41,7 +41,7 @@ defmodule PinchflatWeb.MediaProfileControllerTest do
       Settings.set(onboarding: true)
       conn = get(conn, ~p"/media_profiles/new")
 
-      refute html_response(conn, 200) =~ "MENU"
+      refute html_response(conn, 200) =~ "<span>MENU</span>"
     end
   end
 
diff --git a/test/support/data_case.ex b/test/support/data_case.ex
index d217749..5cb802b 100644
--- a/test/support/data_case.ex
+++ b/test/support/data_case.ex
@@ -15,6 +15,7 @@ defmodule Pinchflat.DataCase do
   """
 
   use ExUnit.CaseTemplate
+  alias Pinchflat.TestingHelperMethods
 
   using do
     quote do
@@ -32,6 +33,8 @@ defmodule Pinchflat.DataCase do
 
   setup tags do
     Pinchflat.DataCase.setup_sandbox(tags)
+    TestingHelperMethods.create_platform_directories()
+
     :ok
   end
 
diff --git a/test/support/testing_helper_methods.ex b/test/support/testing_helper_methods.ex
index ab151ce..00b962f 100644
--- a/test/support/testing_helper_methods.ex
+++ b/test/support/testing_helper_methods.ex
@@ -54,4 +54,11 @@ defmodule Pinchflat.TestingHelperMethods do
     |> render_metadata()
     |> Phoenix.json_library().decode!()
   end
+
+  def create_platform_directories do
+    File.mkdir_p!(Application.get_env(:pinchflat, :media_directory))
+    File.mkdir_p!(Application.get_env(:pinchflat, :metadata_directory))
+    File.mkdir_p!(Application.get_env(:pinchflat, :extras_directory))
+    File.mkdir_p!(Application.get_env(:pinchflat, :tmpfile_directory))
+  end
 end