danvics/pinchflat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactored parse_upload_date

Browse source
This commit is contained in:
Kieran Eglin 2024-05-28 11:57:56 -07:00
parent 3b89a346ef
commit e8c8613074
No known key found for this signature in database
GPG key ID: 193984967FCF432D
4 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/pinchflat/media/media_item.ex
View file

@ -26,7 +26,7 @@ defmodule Pinchflat.Media.MediaItem do
:livestream, :livestream,
:source_id, :source_id,
:short_form_content, :short_form_content,
:upload_date, :uploaded_at,
:upload_date_index, :upload_date_index,
:duration_seconds, :duration_seconds,
# these fields are captured only on download # these fields are captured only on download

5
lib/pinchflat/metadata/metadata_file_helpers.ex
View file

@ -88,14 +88,13 @@ defmodule Pinchflat.Metadata.MetadataFileHelpers do
@doc """ @doc """
Parses an upload date from the YYYYMMDD string returned in yt-dlp metadata Parses an upload date from the YYYYMMDD string returned in yt-dlp metadata
and returns a Date struct. and returns a DateTime struct, appending a time of 00:00:00Z.
Returns Date.t() Returns DateTime.t()
""" """
def parse_upload_date(upload_date) do def parse_upload_date(upload_date) do
<<year::binary-size(4)>> <> <<month::binary-size(2)>> <> <<day::binary-size(2)>> = upload_date <<year::binary-size(4)>> <> <<month::binary-size(2)>> <> <<day::binary-size(2)>> = upload_date
# TODO: test new
case DateTime.from_iso8601("#{year}-#{month}-#{day}T00:00:00Z") do case DateTime.from_iso8601("#{year}-#{month}-#{day}T00:00:00Z") do
{:ok, datetime, _} -> datetime {:ok, datetime, _} -> datetime
_ -> raise "Invalid upload date: #{upload_date}" _ -> raise "Invalid upload date: #{upload_date}"

4
test/pinchflat/metadata/metadata_file_helpers_test.exs
View file

@ -132,10 +132,10 @@ defmodule Pinchflat.Metadata.MetadataFileHelpersTest do
end end
describe "parse_upload_date/1" do describe "parse_upload_date/1" do
test "returns a date from the given metadata upload date" do test "returns a datetime from the given metadata upload date" do
upload_date = "20210101" upload_date = "20210101"
assert Helpers.parse_upload_date(upload_date) == ~D[2021-01-01] assert Helpers.parse_upload_date(upload_date) == ~U[2021-01-01 00:00:00Z]
end end
end end

5
test/support/fixtures/media_fixtures.ex
View file

@ -23,7 +23,7 @@ defmodule Pinchflat.MediaFixtures do
short_form_content: false, short_form_content: false,
media_filepath: "/video/#{Faker.File.file_name(:video)}", media_filepath: "/video/#{Faker.File.file_name(:video)}",
source_id: SourcesFixtures.source_fixture().id, source_id: SourcesFixtures.source_fixture().id,
upload_date: DateTime.utc_now() uploaded_at: DateTime.utc_now()
}) })
|> Pinchflat.Media.create_media_item() |> Pinchflat.Media.create_media_item()
@ -97,7 +97,8 @@ defmodule Pinchflat.MediaFixtures do
description: "desc1", description: "desc1",
aspect_ratio: 1.67, aspect_ratio: 1.67,
duration: 123.45, duration: 123.45,
upload_date: "20210101" upload_date: "20210101",
timestamp: 1_600_000_000
} }
Phoenix.json_library().encode!(media_attributes) Phoenix.json_library().encode!(media_attributes)