From b5fcb4a97fc2aa16eba98098414de121decb78d3 Mon Sep 17 00:00:00 2001 From: Kieran Eglin Date: Tue, 12 Mar 2024 16:15:59 -0700 Subject: [PATCH] Ensured thumbnail is converted to jpg before embedding --- lib/pinchflat/downloading/download_option_builder.ex | 2 +- .../downloading/download_option_builder_test.exs | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/pinchflat/downloading/download_option_builder.ex b/lib/pinchflat/downloading/download_option_builder.ex index 0bb25e2..dabf407 100644 --- a/lib/pinchflat/downloading/download_option_builder.ex +++ b/lib/pinchflat/downloading/download_option_builder.ex @@ -66,7 +66,7 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilder do acc ++ [:write_thumbnail, convert_thumbnail: "jpg"] {:embed_thumbnail, true} -> - acc ++ [:embed_thumbnail] + acc ++ [:embed_thumbnail, convert_thumbnail: "jpg"] _ -> acc diff --git a/test/pinchflat/downloading/download_option_builder_test.exs b/test/pinchflat/downloading/download_option_builder_test.exs index 8d2cc46..22fba78 100644 --- a/test/pinchflat/downloading/download_option_builder_test.exs +++ b/test/pinchflat/downloading/download_option_builder_test.exs @@ -141,6 +141,14 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilderTest do assert :embed_thumbnail in res end + test "convertes thumbnail to jpg when embed_thumbnail is true", %{media_item: media_item} do + media_item = update_media_profile_attribute(media_item, %{embed_thumbnail: true}) + + assert {:ok, res} = DownloadOptionBuilder.build(media_item) + + assert {:convert_thumbnail, "jpg"} in res + end + test "doesn't include these options when not specified", %{media_item: media_item} do media_item = update_media_profile_attribute(media_item, %{embed_thumbnail: false, download_thumbnail: false})