danvics/pinchflat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Converts thumbnails to jpg for better compat (#70)

Browse source
This commit is contained in:
Kieran 2024-03-11 09:03:40 -07:00 committed by GitHub
parent f36bd5abab
commit afe41d2e36
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/pinchflat/yt_dlp/download_option_builder.ex
View file

@ -63,7 +63,7 @@ defmodule Pinchflat.YtDlp.DownloadOptionBuilder do
Enum.reduce(mapped_struct, [], fn attr, acc ->
case {attr, media_profile} do
{{:download_thumbnail, true}, _} ->
acc ++ [:write_thumbnail]
acc ++ [:write_thumbnail, convert_thumbnail: "jpg"]
{{:embed_thumbnail, true}, %{preferred_resolution: pr}} when pr != :audio ->
acc ++ [:embed_thumbnail]

8
test/pinchflat/yt_dlp/download_option_builder_test.exs
View file

@ -125,6 +125,14 @@ defmodule Pinchflat.YtDlp.DownloadOptionBuilderTest do
assert :write_thumbnail in res
end
test "convertes thumbnail to jpg when download_thumbnail is true", %{media_item: media_item} do
media_item = update_media_profile_attribute(media_item, %{download_thumbnail: true})
assert {:ok, res} = DownloadOptionBuilder.build(media_item)
assert {:convert_thumbnail, "jpg"} in res
end
test "includes :embed_thumbnail option when specified", %{media_item: media_item} do
media_item = update_media_profile_attribute(media_item, %{embed_thumbnail: true})