more comments
This commit is contained in:
parent
6bc5086459
commit
a354155203
2 changed files with 5 additions and 3 deletions
|
|
@ -29,5 +29,7 @@ RUN chmod +x ./docker-run.sh
|
||||||
|
|
||||||
# Install Elixir deps
|
# Install Elixir deps
|
||||||
RUN mix deps.get
|
RUN mix deps.get
|
||||||
|
# Gives us iex shell history
|
||||||
|
ENV ERL_AFLAGS="-kernel shell_history enabled"
|
||||||
|
|
||||||
EXPOSE 4008
|
EXPOSE 4008
|
||||||
|
|
|
||||||
|
|
@ -13,9 +13,9 @@ defmodule Pinchflat.MediaClient.Backends.YtDlp.CommandRunner do
|
||||||
|
|
||||||
Returns {:ok, binary()} | {:error, output, status}.
|
Returns {:ok, binary()} | {:error, output, status}.
|
||||||
|
|
||||||
# IDEA: deduplicate command opts, keeping the last one on conflict
|
IDEA: Indexing takes a long time, but the output is actually streamed to stdout.
|
||||||
although possibly not needed (and a LOT easier) if yt-dlp
|
Maybe we could listen to that stream instead so we can index videos as they're discovered.
|
||||||
just ignores duplicate options (ie: look into that)
|
See: https://stackoverflow.com/a/49061086/5665799
|
||||||
"""
|
"""
|
||||||
@impl BackendCommandRunner
|
@impl BackendCommandRunner
|
||||||
def run(url, command_opts) do
|
def run(url, command_opts) do
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue