more comments

This commit is contained in:
Kieran Eglin 2024-01-26 16:17:27 -08:00
parent 6bc5086459
commit a354155203
No known key found for this signature in database
GPG key ID: 193984967FCF432D
2 changed files with 5 additions and 3 deletions

View file

@ -29,5 +29,7 @@ RUN chmod +x ./docker-run.sh
# Install Elixir deps
RUN mix deps.get
# Gives us iex shell history
ENV ERL_AFLAGS="-kernel shell_history enabled"
EXPOSE 4008

View file

@ -13,9 +13,9 @@ defmodule Pinchflat.MediaClient.Backends.YtDlp.CommandRunner do
Returns {:ok, binary()} | {:error, output, status}.
# IDEA: deduplicate command opts, keeping the last one on conflict
although possibly not needed (and a LOT easier) if yt-dlp
just ignores duplicate options (ie: look into that)
IDEA: Indexing takes a long time, but the output is actually streamed to stdout.
Maybe we could listen to that stream instead so we can index videos as they're discovered.
See: https://stackoverflow.com/a/49061086/5665799
"""
@impl BackendCommandRunner
def run(url, command_opts) do