danvics/pinchflat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Updated basic auth parsing to ignore empty strings

Browse source
This commit is contained in:
Kieran Eglin 2024-03-04 13:25:12 -08:00
parent 1b404086d5
commit 82124b0669
No known key found for this signature in database
GPG key ID: 193984967FCF432D
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/pinchflat_web/router.ex
View file

@ -54,10 +54,14 @@ defmodule PinchflatWeb.Router do
username = Application.get_env(:pinchflat, :basic_auth_username)
password = Application.get_env(:pinchflat, :basic_auth_password)
if username && password do
if credential_set?(username) && credential_set?(password) do
Plug.BasicAuth.basic_auth(conn, username: username, password: password, realm: "Pinchflat")
else
conn
end
end
defp credential_set?(credential) do
credential && credential != ""
end
end

9
test/pinchflat_web/routing_test.exs
View file

@ -44,5 +44,14 @@ defmodule PinchflatWeb.RoutingTest do
assert conn.status == 200
end
test "it treats empty strings as not being set when using basic auth", %{conn: conn} do
Application.put_env(:pinchflat, :basic_auth_username, "")
Application.put_env(:pinchflat, :basic_auth_password, "pass")
conn = get(conn, "/")
assert conn.status == 200
end
end
end