danvics/pinchflat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Stopped notifications from being sent if the source doesn't download (#218)

Browse source
This commit is contained in:
Kieran 2024-05-01 08:56:15 -07:00 committed by GitHub
parent 3f74f199dc
commit 8051107d32
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/pinchflat/notifications/source_notifications.ex
View file

@ -53,7 +53,11 @@ defmodule Pinchflat.Notifications.SourceNotifications do
end
defp relevant_media_item_count(source) do
pending_media_item_count(source) + downloaded_media_item_count(source)
if source.download_media do
pending_media_item_count(source) + downloaded_media_item_count(source)
else
0
end
end
defp pending_media_item_count(source) do

11
test/pinchflat/notifications/source_notifications_test.exs
View file

@ -60,6 +60,17 @@ defmodule Pinchflat.Notifications.SourceNotificationsTest do
end)
end
test "does not send a notification if the source is set to not download media" do
source = source_fixture(%{download_media: false})
expect(AppriseRunnerMock, :run, 0, fn _, _ -> {:ok, ""} end)
SourceNotifications.wrap_new_media_notification(@apprise_servers, source, fn ->
media_item_fixture(%{source_id: source.id, media_filepath: nil})
media_item_fixture(%{source_id: source.id, media_filepath: "file.mp4"})
end)
end
test "returns the value of the function" do
source = source_fixture()
expect(AppriseRunnerMock, :run, 0, fn _, _ -> {:ok, ""} end)