From 53a8dd3a03035dea511bcbf96f93e274db661cf0 Mon Sep 17 00:00:00 2001 From: Kieran Eglin Date: Thu, 11 Apr 2024 15:14:00 -0700 Subject: [PATCH] Added tests for new remux options --- lib/pinchflat/downloading/download_option_builder.ex | 1 - test/pinchflat/downloading/download_option_builder_test.exs | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/pinchflat/downloading/download_option_builder.ex b/lib/pinchflat/downloading/download_option_builder.ex index 2fb603d..69fd061 100644 --- a/lib/pinchflat/downloading/download_option_builder.ex +++ b/lib/pinchflat/downloading/download_option_builder.ex @@ -106,7 +106,6 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilder do end defp quality_options(media_profile) do - # TODO: test video_codec_option = fn res -> [format_sort: "res:#{res},+codec:avc:m4a", remux_video: "mp4"] end diff --git a/test/pinchflat/downloading/download_option_builder_test.exs b/test/pinchflat/downloading/download_option_builder_test.exs index 5314f89..d5c4dab 100644 --- a/test/pinchflat/downloading/download_option_builder_test.exs +++ b/test/pinchflat/downloading/download_option_builder_test.exs @@ -240,6 +240,7 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilderTest do assert {:ok, res} = DownloadOptionBuilder.build(media_item) assert {:format_sort, "res:#{resolution},+codec:avc:m4a"} in res + assert {:remux_video, "mp4"} in res end) end @@ -250,6 +251,8 @@ defmodule Pinchflat.Downloading.DownloadOptionBuilderTest do assert :extract_audio in res assert {:format, "bestaudio[ext=m4a]"} in res + + refute {:remux_video, "mp4"} in res end end