79c329ceda
Some checks failed
Forgejo Android APK / Root app tests (push) Successful in 55s
Forgejo Docker Build / Root app tests (push) Successful in 48s
Forgejo Android APK / Build signed APK (push) Successful in 2m0s
Forgejo Docker Build / Build Docker image (push) Successful in 16s
Forgejo Docker Build / Deploy to the host (push) Failing after 0s
Adds the admin fixture the Search Sources screen needed, and repairs the reason no browser-driving e2e test could log in at all. The sign-in failure first. The suite drove the app over http on a container hostname, which is not a secure context, so the browser provides no crypto.randomUUID. AccountBoundary calls it to mint a session generation on every sign-in; the call threw, the boot handler's catch swallowed it, and every test landed on the login screen holding a perfectly valid session. Measured: isSecureContext false and randomUUID undefined on http://pediatric-ai-scribe-e2e:3000, both true on http://127.0.0.1:3553, where boundary.enter() returns true and the app enters. Chrome's --unsafely-treat-insecure-origin-as-secure was tried first and does not work: Playwright rejects the --user-data-dir it must be paired with, and the flag alone leaves isSecureContext false. Loopback needs no flags, so the runner now uses the host network and the published port. The seed is new. The e2e user was a registration someone did by hand once that the shared Postgres happened to keep — enough to log in and no more. There was no admin account, so nothing under /api/admin could be tested through a real request, which is how the Search Sources card came to be verified by reading its markup. e2e/seed.js creates both accounts and reconciles an existing one, so a leftover with the wrong role cannot fail the suite for a reason unrelated to the code. It resets passwords and grants admin, so it refuses any address outside @ped-ai.test. The runner seeds before it tests. The new spec covers what markup-reading could not: that an ordinary account is refused the settings and never offered the Admin menu item, that no API key comes back readable, that the Test button reports each source separately, and that every control the save handler reads exists in a real render. Each account gets its own browser context, because AccountBoundary allows one owner per document and freezing the page on a second is the behaviour, not a bug. 10/10 pass on both projects. Two unit tests pin the loopback requirement and the seed's domain guard so neither can be undone quietly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dv6sqaY6Vq3ChZHMem3cnU
60 lines
3.3 KiB
JavaScript
60 lines
3.3 KiB
JavaScript
// ============================================================
|
|
// E2E HARNESS
|
|
// ============================================================
|
|
// The browser suite is the only thing that exercises the app the way a person
|
|
// uses it, so the two ways it silently stops doing that are worth pinning.
|
|
//
|
|
// Both were found the same day: every browser-driving spec was failing, and had
|
|
// been, because the harness could not sign in at all.
|
|
// ============================================================
|
|
|
|
const test = require('node:test');
|
|
const assert = require('node:assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const read = p => fs.readFileSync(path.join(__dirname, '..', p), 'utf8');
|
|
|
|
test('the browser suite runs against a loopback origin, because the app needs a secure context', () => {
|
|
// AccountBoundary mints a session generation with crypto.randomUUID() on
|
|
// every sign-in. On a non-loopback http origin the browser provides no
|
|
// crypto.randomUUID at all, so that call throws, the boot handler's catch
|
|
// swallows it, and every test lands on the login screen with a valid session
|
|
// in hand. Measured: isSecureContext false and randomUUID undefined on
|
|
// http://pediatric-ai-scribe-e2e:3000, both true on http://127.0.0.1:3553.
|
|
assert.match(read('public/js/accountBoundary.js'), /crypto\.randomUUID\(\)/,
|
|
'if this call is gone, the loopback requirement may have gone with it');
|
|
|
|
const config = read('e2e/playwright.config.js');
|
|
const fixtures = read('e2e/fixtures.js');
|
|
const runner = read('scripts/e2e.sh');
|
|
// host.docker.internal is a hostname, not loopback, and was the old default
|
|
// in all three places.
|
|
for (const [name, src] of [['config', config], ['fixtures', fixtures], ['runner', runner]]) {
|
|
assert.ok(!/host\.docker\.internal/.test(src), name + ' must not default to a non-loopback origin');
|
|
}
|
|
assert.match(config, /127\.0\.0\.1:3553/, 'playwright baseURL is loopback');
|
|
assert.match(fixtures, /127\.0\.0\.1:3553/, 'the fixtures authenticate against loopback');
|
|
assert.match(runner, /--network=host/, 'which needs the host network to reach the published port');
|
|
assert.match(read('docker-compose.e2e.yml'), /http:\/\/127\.0\.0\.1:3553/, 'and CORS has to allow it');
|
|
});
|
|
|
|
test('the e2e accounts are seeded, and the seed cannot touch a real one', () => {
|
|
const seed = read('e2e/seed.js');
|
|
// Both roles. Without an admin account nothing under /api/admin could be
|
|
// tested through a real request, which is how the Search Sources screen came
|
|
// to be checked by reading its markup instead.
|
|
assert.match(seed, /role: 'user'/);
|
|
assert.match(seed, /role: 'admin'/);
|
|
// It resets passwords and grants the admin role, so the domain guard is the
|
|
// part that matters: a mistyped environment variable must not be able to
|
|
// reach a real account.
|
|
assert.match(seed, /refusing to seed/);
|
|
assert.match(seed, /TEST_DOMAIN = '@ped-ai\.test'/);
|
|
assert.match(seed, /email\.slice\(-TEST_DOMAIN\.length\) !== TEST_DOMAIN/);
|
|
// Reconciles rather than only creating, so a leftover account with the wrong
|
|
// role cannot fail the suite for a reason unrelated to the code.
|
|
assert.match(seed, /UPDATE users SET password = \?, name = \?, role = \?, email_verified = true, disabled = false/);
|
|
|
|
// And the runner seeds before it tests, so nobody has to remember to.
|
|
assert.match(read('scripts/e2e.sh'), /node e2e\/seed\.js/);
|
|
});
|