22683f3584
Some checks failed
Forgejo Android APK / Root app tests (push) Successful in 46s
Forgejo Docker Build / Root app tests (push) Successful in 56s
Forgejo Android APK / Build signed APK (push) Successful in 2m6s
Forgejo Docker Build / Build Docker image (push) Successful in 15s
Forgejo Docker Build / Deploy to the host (push) Failing after 0s
The sign-in screen asks for an email first, then offers both ways in together: a six-digit code sent to that address, or the password. Beside rather than instead — a code depends on mail being delivered and a password does not, so neither may be the only route. "Use a different email" goes back a step, and creating an account stays where it was. What keeps it from being a second, weaker front door: - Only a bcrypt hash is stored, so a code read out of the database is not a working credential. - Ten minutes, single use, marked used before the session is issued so a replay cannot race it, and requesting a new one deletes the old. - Five wrong guesses burn it. Six digits is a million possibilities, which is plenty against a person and nothing against a script with unlimited tries. - Requesting a code answers identically whether or not the address exists, and every verify failure returns one message. A sign-in screen that says "no such account" is a way of finding out who has one. - Two-factor still applies: a code proves you can read the mailbox, which is one factor, and an account that asked for a second still wants it. - Its own rate limits, tighter for requesting than for attempting, because requesting sends mail to someone else's address. These had to be separate limiters: Express matches app.use paths on segment boundaries, so /api/auth/login does not cover /api/auth/login-code — checked against a real router rather than assumed. Two bugs found while building it, both mine: authFetch keeps an allowlist of endpoints callable with no verified owner and rejects everything else before it is sent. The new endpoints were not on it, so the request never left the browser and surfaced as "Connection error". reveal() hid elements by appending 'hidden' to className and showed them with a non-global replace, so hiding twice left two copies and showing stripped one. The "use a different email" link never reappeared. It uses classList now, which is idempotent. Verified against the running server: correct code signs in, the same code again is refused, a superseded code is refused, five wrong guesses burn it, an expired one is refused, and the stored value is a hash. In the browser: requesting a code advances the screen, a wrong code is refused without losing the screen, and the password route still signs in. Not yet demonstrated: a correct code typed into the browser. The harness keeps racing the one-live-code rule — the page's own request supersedes whatever code the test holds, and with SMTP off the delivered one cannot be read. The same request reaches the server on the wrong-code path, and the endpoint itself is verified, but that last step is untested end to end. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dv6sqaY6Vq3ChZHMem3cnU |
||
|---|---|---|
| .. | ||
| account-boundary.test.js | ||
| admin-clinical-assistant-wiring.test.js | ||
| admin-docs-toc.test.js | ||
| assistant-attachment-roundtrip.test.js | ||
| assistant-autosave.test.js | ||
| assistant-citation-modal.test.js | ||
| assistant-citations.test.js | ||
| assistant-component-css.test.js | ||
| assistant-export-owner.test.js | ||
| assistant-image-attachments.test.js | ||
| assistant-image-done.test.js | ||
| assistant-image-intent.test.js | ||
| assistant-math-mhchem.test.js | ||
| assistant-message-actions.test.js | ||
| assistant-mobile.test.js | ||
| assistant-saved-tables.test.js | ||
| assistant-sharing-boundary.test.js | ||
| assistant-sources-cleaning.test.js | ||
| assistant-translate.test.js | ||
| assistant-user-markdown.test.js | ||
| assistant-voice.test.js | ||
| assistant-workspace-layout.test.js | ||
| backend-hardening.test.js | ||
| bedside-respiratory-ventilation.test.js | ||
| build-id.test.js | ||
| calc-math.test.js | ||
| calculators-data.test.js | ||
| clinical-assistant-prompt-pool.test.js | ||
| clinical-conversation.test.js | ||
| clinical-generation-options.test.js | ||
| clinical-mcp-session-lifecycle.test.js | ||
| clinical-notes-entrypoints.test.js | ||
| clinical-release-integration.test.js | ||
| clinical-retrieval-title.test.js | ||
| clinical-table-preservation.test.js | ||
| e2e-harness.test.js | ||
| embeddings-provider.test.js | ||
| extension-transfer.test.js | ||
| frontend-prompt-env.test.js | ||
| frontend-rendering-safety.test.js | ||
| generated-image-cache.test.js | ||
| generated-image-storage.test.js | ||
| generated-image-tools.test.js | ||
| generated-images-ui.test.js | ||
| generated-images.integration.js | ||
| learning-hub-ai-category.test.js | ||
| learning-hub-ai-panel-controller.test.js | ||
| learning-hub-editor.test.js | ||
| learning-hub-manual-category.test.js | ||
| learning-hub-quiz-controller.test.js | ||
| learning-hub-webdav-controller.test.js | ||
| learning-retrieval.test.js | ||
| login-codes.test.js | ||
| mcp-shutdown.test.js | ||
| metrics.test.js | ||
| model-defaults.test.js | ||
| module-entrypoints.test.js | ||
| my-resources.test.js | ||
| notes-sanitize.test.js | ||
| patient-takehome.test.js | ||
| pe-guide-data.test.js | ||
| policy-flows.test.js | ||
| policy-ui.test.js | ||
| prompt-administration.test.js | ||
| release.test.js | ||
| session-quiz-ed-regressions.test.js | ||
| slide-spec.test.js | ||
| stt-provider.test.js | ||
| transcription-memory-policy.test.js | ||
| tts-provider.test.js | ||
| web-search.test.js | ||
| well-visit-data.test.js | ||