b6cfcaa1e9
571 categories, 21 uploaded documents, 14 articles, 8 card decks, 30 shared tests and 2 questions carried somebody's name — mostly daniel@danvics.com, which is not even the working administrator any more. So "who may edit this" partly depended on who happened to create it, and handing the site to somebody else would have meant rewriting every one of those rows. Migration q6a7b8c9d0e1 empties those owner columns and makes them nullable, because ownerless is now a legitimate state and a NOT NULL owner is exactly what forced a name onto every row. Nothing is deleted and nothing moves. What keeps its owner, deliberately: attempts, notes, favourites, collections, folders, study-plan progress, and the quizzes that are somebody's own sittings rather than shared bank tests. study_plans needed nothing — it never had an owner column. Then the code, so it cannot grow back. Authorship is no longer a way in anywhere: may_edit_question and can_edit_article ask the role and the grants and nothing else; the article draft, status and delete paths lost their "or you wrote it" arm; decks are the bank's, so an educator reaches any of them and a learner reaches the shared ones; documents are the corpus, so they are editors-only rather than "mine"; and every creation path writes user_id NULL. The bank listing's "mine" facet went with it — it counted nothing and could only ever count nothing. Verified against production as a real learner account: every bank write 403s, admin settings 403, documents empty. As an admin, everything opens. Also: a category grant no longer offers Editorial in the menu. It offers Questions and Images, which is what a grant covers; Editorial is the whole library's review queue and its route is moderator-only, so the entry was a door that answered "Not yours to open". Six tests changed rather than deleted — they asserted the old model, and each now asserts the new one: writing an article does not make it yours, writing a question does not make it yours, an answer image is not opened by authorship, the tutor is not opened by authorship. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TqXevQJhxFrM7jJg82cgZN
70 lines
2.6 KiB
Python
70 lines
2.6 KiB
Python
"""Bank content belongs to a role, not to a person.
|
|
|
|
The bank was full of rows with somebody's name on them: 571 categories, 21
|
|
uploaded documents, 14 articles, 8 card decks, the shared tests. Most of them
|
|
said daniel@danvics.com, an address that is not even the working administrator
|
|
any more — so "who may edit this" partly depended on who happened to have
|
|
created it years ago, and handing the site to somebody else would have meant
|
|
rewriting every one of those rows.
|
|
|
|
Ownership of the bank is now the `admin` role plus CategoryGrant, and these
|
|
columns are emptied to say so. Nothing is deleted and no row moves: only the
|
|
name comes off.
|
|
|
|
What keeps its owner, deliberately, because it is genuinely one person's:
|
|
quiz_attempts, question_notes, article_section_notes, favorites,
|
|
user_collections, question_folders, study_plan_* progress, and the quizzes
|
|
that are somebody's own sittings (is_shared = 0) rather than bank tests.
|
|
|
|
study_plans needed nothing: it never had an owner column.
|
|
|
|
Revision ID: q6a7b8c9d0e1
|
|
Revises: p5f6a7b8c9d0
|
|
"""
|
|
from alembic import op
|
|
import sqlalchemy as sa
|
|
|
|
revision = "q6a7b8c9d0e1"
|
|
down_revision = "p5f6a7b8c9d0"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
#: Everything in the bank, and the condition that picks the bank rows out of a
|
|
#: table that also holds personal ones.
|
|
BANK = [
|
|
("question_categories", None),
|
|
("articles", None),
|
|
("pdf_documents", None),
|
|
("flashcard_decks", None),
|
|
("questions", None),
|
|
("media_assets", None),
|
|
("media_libraries", None),
|
|
("quiz_categories", None),
|
|
# A shared test is the bank's; an unshared one is a sitting of somebody's
|
|
# own and stays theirs.
|
|
("quizzes", "is_shared = 1"),
|
|
]
|
|
|
|
|
|
#: Tables whose user_id was declared NOT NULL. "Ownerless" is now a legitimate
|
|
#: state for bank content, so the column has to be allowed to say so — and a
|
|
#: NOT NULL owner column is exactly the thing that forced a person's name onto
|
|
#: every row in the first place.
|
|
NULLABLE = ("question_categories", "pdf_documents", "flashcard_decks",
|
|
"quiz_categories", "quizzes")
|
|
|
|
|
|
def upgrade():
|
|
for table in NULLABLE:
|
|
op.alter_column(table, "user_id", existing_type=sa.Integer(), nullable=True)
|
|
for table, where in BANK:
|
|
clause = f" AND {where}" if where else ""
|
|
op.execute(sa.text(
|
|
f"UPDATE {table} SET user_id = NULL WHERE user_id IS NOT NULL{clause}"))
|
|
|
|
|
|
def downgrade():
|
|
# Deliberately not reversible. The names are not recorded anywhere once
|
|
# they are gone, and inventing an owner would be worse than admitting the
|
|
# information is not here: restore from the dump taken beside this change.
|
|
pass
|