danvics/pdf-quiz-generator
1
0
Fork 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

Fix mark-complete 403 for course creators previewing lessons

Browse source 
Creators preview courses without enrolling, so markComplete and SCORM
onComplete were hitting the progress endpoint and getting 403. Now
guarded by enrollment check — buttons hidden and callbacks skipped
for non-enrolled users.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Daniel 2026-04-11 02:25:21 +02:00
parent 2db5cb74d7
commit b32fc65236
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
frontend/src/pages/CourseDetailPage.jsx
View file

@ -193,6 +193,7 @@ export default function CourseDetailPage() {
} }
const markComplete = async (lessonId) => { const markComplete = async (lessonId) => {
if (!course.my_enrollment) return
try { try {
await api.put(`/courses/${courseId}/lessons/${lessonId}/progress`, { status: 'completed' }) await api.put(`/courses/${courseId}/lessons/${lessonId}/progress`, { status: 'completed' })
setCompletedLessons(prev => { const n = new Set(prev); n.add(lessonId); return n }) setCompletedLessons(prev => { const n = new Set(prev); n.add(lessonId); return n })
@ -386,12 +387,12 @@ export default function CourseDetailPage() {
)} )}
</div> </div>
<div style={{ display: 'flex', gap: 8 }}> <div style={{ display: 'flex', gap: 8 }}>
{!completedLessons.has(activeLesson.id) && ( {enrolled && !completedLessons.has(activeLesson.id) && (
<button className="btn btn-primary btn-sm" onClick={() => markComplete(activeLesson.id)}> <button className="btn btn-primary btn-sm" onClick={() => markComplete(activeLesson.id)}>
Mark Complete &#10003; Mark Complete &#10003;
</button> </button>
)} )}
{completedLessons.has(activeLesson.id) && ( {enrolled && completedLessons.has(activeLesson.id) && (
<span style={{ color: 'var(--correct-fg)', fontWeight: 600, fontSize: '0.88rem', padding: '6px 0' }}> <span style={{ color: 'var(--correct-fg)', fontWeight: 600, fontSize: '0.88rem', padding: '6px 0' }}>
&#10003; Completed &#10003; Completed
</span> </span>
@ -555,7 +556,7 @@ export default function CourseDetailPage() {
lessonId={activeLesson.id} lessonId={activeLesson.id}
courseId={courseId} courseId={courseId}
onComplete={() => { onComplete={() => {
if (!completedLessons.has(activeLesson.id)) { if (enrolled && !completedLessons.has(activeLesson.id)) {
markComplete(activeLesson.id) markComplete(activeLesson.id)
} }
}} }}