c81a863e69
PR #596 brought forward automatic generation of Linux manual pages for Oxipng, which is executed every time Oxipng is built. However, while building manpages on every build is convenient for Oxipng development and doing so didn't catch my attention initially, it introduces noticeable inefficiencies for crates using Oxipng as a library: during their build, Oxipng manpages are also built, even though most dependent crates won't use such artifacts, as they are not considered part of the public Oxipng crate API or even appropriate for non-human consumption. Moreover, generating manpages depends on `clap`, which is a heavyweight dependency: according to a fresh `cargo build --timings --release` on my development workstation, its `clap_builder` dependency is the third most time consuming unit to build, totalling 1.5 s (out of 11.7 s, or 12.8%). And there is no way for dependent crates to turn this off: [`build-dependencies` cannot be conditional on crate features](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies). Potentially using other `cfg` hacks to either enable or disable manpage generation is unergonomic, if not outright disallowed. Besides reducing their compilation time cost, dependent crates may also want to trim the size of their dependency tree, avoiding unnecessary dependency downloads in the process. Therefore, a better solution to conditionally build manpages in a way convenient for both Oxipng maintainers and downstream consumers is needed. My proposal implemented in this PR is to leverage the [`cargo-xtask`](https://github.com/matklad/cargo-xtask) convention to define an auxiliary crate to move the manpage generation logic and dependencies to, which is not part of the `oxipng` crate published on `crates.io`. That way Oxipng maintainers and packagers can still generate manpages at request with ease, without any automation being noticeable to uninterested crate consumers. And as a side benefit, Oxipng maintainers can also benefit from slightly faster iteration times due to the lack of a build script for the main crate. The new `mangen` xtask can be run at any time with `cargo xtask mangen`. The generated manpages are now available at `target/xtask/mangen/manpages`. Existing deployment scripts were updated accordingly.
107 lines
3.4 KiB
YAML
107 lines
3.4 KiB
YAML
name: deploy
|
|
|
|
on:
|
|
push:
|
|
tags:
|
|
- 'v*.*.*'
|
|
|
|
permissions:
|
|
actions: read
|
|
contents: write
|
|
|
|
jobs:
|
|
deploy:
|
|
name: Deploy release
|
|
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
|
|
# Prevent job from running on forks
|
|
if: ${{ !github.event.repository.fork }}
|
|
|
|
strategy:
|
|
matrix:
|
|
target:
|
|
- x86_64-unknown-linux-gnu
|
|
- x86_64-unknown-linux-musl
|
|
- aarch64-unknown-linux-gnu
|
|
- aarch64-unknown-linux-musl
|
|
- x86_64-pc-windows-msvc
|
|
- i686-pc-windows-msvc
|
|
- x86_64-apple-darwin
|
|
- aarch64-apple-darwin
|
|
|
|
steps:
|
|
- name: Checkout source
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Get the Oxipng version
|
|
id: oxipngMeta
|
|
run: echo "version=$(cargo metadata --format-version 1 --no-deps | jq -r '.packages[] | select(.name == "oxipng").version')"
|
|
>> "$GITHUB_OUTPUT"
|
|
|
|
- name: Retrieve ${{ matrix.target }} binary
|
|
uses: dawidd6/action-download-artifact@v6
|
|
with:
|
|
workflow: oxipng.yml
|
|
commit: ${{ env.GITHUB_SHA }}
|
|
name: Oxipng binary (${{ matrix.target }})
|
|
path: target
|
|
|
|
- name: Generate up to date manual
|
|
run: scripts/manual.sh
|
|
|
|
- name: Build archives
|
|
working-directory: target
|
|
run: |
|
|
ARCHIVE_NAME="oxipng-${{ steps.oxipngMeta.outputs.version }}-${{ matrix.target }}"
|
|
|
|
mkdir "$ARCHIVE_NAME"
|
|
cp ../CHANGELOG.md ../README.md ../MANUAL.txt "$ARCHIVE_NAME"
|
|
|
|
case '${{ matrix.target }}' in
|
|
*-windows-*)
|
|
cp ../LICENSE "$ARCHIVE_NAME/LICENSE.txt"
|
|
cp oxipng.exe "$ARCHIVE_NAME"
|
|
zip "${ARCHIVE_NAME}.zip" "$ARCHIVE_NAME"/*;;
|
|
*)
|
|
cp ../LICENSE "$ARCHIVE_NAME"
|
|
cp oxipng "$ARCHIVE_NAME"
|
|
# Execute permissions are not stored in artifact files,
|
|
# so make the binary world-executable to meet user
|
|
# expectations set by preceding releases.
|
|
# Related issue:
|
|
# https://github.com/shssoichiro/oxipng/issues/575
|
|
chmod ugo+x "$ARCHIVE_NAME"/oxipng
|
|
tar -vczf "${ARCHIVE_NAME}.tar.gz" "$ARCHIVE_NAME"/*;;
|
|
esac
|
|
|
|
- name: Install QEMU and AArch64 cross compiler
|
|
if: matrix.target == 'aarch64-unknown-linux-gnu'
|
|
run: |
|
|
sudo apt-get -yq update
|
|
# The shared libc AArch64 libraries are needed for cargo deb below
|
|
# to be able to infer package requirements with dpkg-shlibdeps
|
|
# properly
|
|
sudo apt-get -yq install libc6-arm64-cross libgcc-s1-arm64-cross
|
|
|
|
- name: Build deb archives
|
|
if: endsWith(matrix.target, '-linux-gnu')
|
|
run: |
|
|
mkdir -p "target/${{ matrix.target }}/release"
|
|
mv target/oxipng "target/${{ matrix.target }}/release"
|
|
cargo install --locked cargo-deb
|
|
cargo deb --target "${{ matrix.target }}" --no-build --no-strip
|
|
|
|
- name: Create release notes
|
|
run: tail -n +3 CHANGELOG.md | sed -e '/^$/,$d' > RELEASE_NOTES.txt
|
|
|
|
- name: Create release
|
|
uses: softprops/action-gh-release@v2
|
|
with:
|
|
name: v${{ steps.oxipngMeta.outputs.version }}
|
|
body_path: RELEASE_NOTES.txt
|
|
files: |
|
|
target/*.zip
|
|
target/*.tar.gz
|
|
target/${{ matrix.target }}/debian/*.deb
|