As commented in issues https://github.com/shssoichiro/oxipng/issues/444 and https://github.com/shssoichiro/oxipng/issues/518, there is some user interest for distributing binaries for each unstable commit, and target ARM64 platforms. Personally, I think both suggestions are useful for the project, as uploading binary artifacts for each commit might help interested users to catch regressions and give feedback earlier, and powerful ARM64 platforms are becoming increasingly popular due to some cloud services (e.g., Amazon EC2, Azure VMs, Oracle Cloud) offering cheaper plans for this hardware, in addition to the well-known push for ARM by Apple with their custom M1 chips. These changes make the CI target ARM64 as a first-class citizen. Because the public GitHub actions runners can only be hosted on x64 for now, I resorted to cross-compilation, [Debian's multiarch](https://elinux.org/images/d/d8/Multiarch_and_Why_You_Should_Care-_Running%2C_Installing_and_Crossbuilding_With_Multiple_Architectures.pdf), and QEMU to build, get ARM64 C library dependencies, and run tests, respectively. When the CI workflow finishes, a release CLI binary artifact is now uploaded, which can be downloaded from the workflow run page on the GitHub web interface. In addition, these changes also introduce some cleanup and miscellaneous improvements and changes to the CI workflow: - Tests are run using [`nextest`](https://nexte.st/) instead of `cargo test`, which substantially speeds up their execution. (On my development workstation, `cargo test --release` takes around 10.67 s, while `cargo nextest run --release` takes around 6.02 s.) - The dependencies on unmaintained `actions-rs` actions were dropped in favor of running Cargo commands directly, or using `giraffate/clippy-action` for pretty inline annotations for Clippy. This gets rid of the deprecation warnings for each workflow run. - Most CI steps are run with a nightly Rust toolchain now, which allows to take advantage of the latest Clippy lints and codegen improvements. In my experience, when not relying on specific nightly features or compiler internals, Rust does a pretty good job at making it possible to rely on a rolling-release compiler for CI, as breakage is extremely rare and thus offset by the improved features. - The MSRV check was moved to a separate job with less steps, so that it takes less of a toll on total workflow run minutes. ## Pending tasks - [x] Generate universal macOS binaries with `lipo` (i.e., containing both `aarch64` and `x64` code) - [x] Tirelessly fix the stupid errors that tend to happen when deploying a new CI workflow for the first time - [x] Think what to do with the `deploy.yml` workflow. Should it fetch artifacts from the CI job instead of building them again? - [x] Maybe bring back 32-bit Windows binaries. Are they actually useful for somebody, or just a way to remember the good old days? --------- Co-authored-by: Josh Holmer <jholmer.in@gmail.com>
181 lines
5.9 KiB
YAML
181 lines
5.9 KiB
YAML
name: oxipng
|
|
|
|
on:
|
|
push:
|
|
pull_request:
|
|
types:
|
|
- opened
|
|
- synchronize
|
|
workflow_dispatch:
|
|
|
|
jobs:
|
|
ci:
|
|
name: CI
|
|
|
|
runs-on: ${{ matrix.os }}
|
|
timeout-minutes: 60
|
|
|
|
# Prevent tags and in-repo PRs from triggering this workflow more than once for a commit
|
|
if: github.ref_type != 'tag' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork)
|
|
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
target:
|
|
- x86_64-unknown-linux-gnu
|
|
- x86_64-unknown-linux-musl
|
|
- aarch64-unknown-linux-gnu
|
|
- aarch64-unknown-linux-musl
|
|
- x86_64-pc-windows-msvc
|
|
- i686-pc-windows-msvc
|
|
- x86_64-apple-darwin
|
|
- aarch64-apple-darwin
|
|
|
|
include:
|
|
- target: x86_64-unknown-linux-gnu
|
|
os: ubuntu-22.04
|
|
target-apt-arch: amd64
|
|
- target: x86_64-unknown-linux-musl
|
|
os: ubuntu-22.04
|
|
target-apt-arch: amd64
|
|
- target: aarch64-unknown-linux-gnu
|
|
os: ubuntu-22.04
|
|
target-apt-arch: arm64
|
|
- target: aarch64-unknown-linux-musl
|
|
os: ubuntu-22.04
|
|
target-apt-arch: arm64
|
|
- target: x86_64-pc-windows-msvc
|
|
os: windows-latest
|
|
- target: i686-pc-windows-msvc
|
|
os: windows-latest
|
|
- target: x86_64-apple-darwin
|
|
os: macos-latest
|
|
- target: aarch64-apple-darwin
|
|
os: macos-latest
|
|
|
|
env:
|
|
CARGO_BUILD_TARGET: ${{ matrix.target }}
|
|
|
|
steps:
|
|
- name: Checkout source
|
|
uses: actions/checkout@v3
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- name: Set up Ubuntu multiarch
|
|
if: startsWith(matrix.os, 'ubuntu') && matrix.target-apt-arch != 'amd64'
|
|
run: |
|
|
readonly DISTRO_CODENAME=jammy
|
|
sudo dpkg --add-architecture "${{ matrix.target-apt-arch }}"
|
|
sudo sed -i "s/^deb http/deb [arch=$(dpkg-architecture -q DEB_HOST_ARCH)] http/" /etc/apt/sources.list
|
|
for suite in '' '-updates' '-backports' '-security'; do
|
|
echo "deb [arch=${{ matrix.target-apt-arch }}] http://ports.ubuntu.com/ $DISTRO_CODENAME$suite main universe multiverse" | \
|
|
sudo tee -a /etc/apt/sources.list >/dev/null
|
|
done
|
|
|
|
- name: Install musl development files
|
|
if: endsWith(matrix.target, '-musl')
|
|
run: |
|
|
sudo apt-get -yq update
|
|
sudo apt-get -yq install musl-tools musl-dev:${{ matrix.target-apt-arch }}
|
|
|
|
- name: Install QEMU and AArch64 cross compiler
|
|
if: startsWith(matrix.target, 'aarch64-unknown-linux')
|
|
run: |
|
|
sudo apt-get -yq update
|
|
# libc6 must be present to run executables dynamically linked
|
|
# against glibc for the target architecture
|
|
sudo apt-get -yq install qemu-user gcc-aarch64-linux-gnu libc6:arm64
|
|
|
|
- name: Cache Cargo artifacts
|
|
uses: Swatinem/rust-cache@v2
|
|
|
|
- name: Install Rust toolchain
|
|
uses: dtolnay/rust-toolchain@v1
|
|
with:
|
|
toolchain: nightly
|
|
targets: ${{ env.CARGO_BUILD_TARGET }}
|
|
components: clippy, rustfmt
|
|
|
|
- name: Install nextest
|
|
uses: taiki-e/install-action@nextest
|
|
|
|
- name: Run rustfmt
|
|
if: matrix.target == 'x86_64-unknown-linux-gnu'
|
|
run: cargo fmt --check
|
|
|
|
- name: Run Clippy (no default features)
|
|
if: matrix.target == 'x86_64-unknown-linux-gnu'
|
|
uses: giraffate/clippy-action@v1
|
|
with:
|
|
clippy_flags: --no-deps --all-targets --no-default-features -- -D warnings
|
|
reporter: github-check
|
|
fail_on_error: true
|
|
|
|
- name: Run Clippy (all features)
|
|
if: matrix.target == 'x86_64-unknown-linux-gnu'
|
|
uses: giraffate/clippy-action@v1
|
|
with:
|
|
clippy_flags: --no-deps --all-targets --all-features -- -D warnings
|
|
reporter: github-check
|
|
fail_on_error: true
|
|
|
|
# There aren't good user-mode ARM64 emulators we can use on x64 macOS hosts.
|
|
# QEMU doesn't have any plans to add such support due to a lack of kernel
|
|
# syscall stability guarantees: https://gitlab.com/qemu-project/qemu/-/issues/1682
|
|
- name: Run tests
|
|
if: matrix.target != 'aarch64-apple-darwin'
|
|
run: |
|
|
cargo nextest run --release --features sanity-checks
|
|
cargo test --doc --release --features sanity-checks
|
|
|
|
- name: Build tests (ARM64 macOS only)
|
|
if: matrix.target == 'aarch64-apple-darwin'
|
|
run: cargo test --release --features sanity-checks --no-run
|
|
|
|
- name: Build benchmarks
|
|
run: cargo bench --no-run
|
|
|
|
- name: Build docs
|
|
if: matrix.target == 'x86_64-unknown-linux-gnu'
|
|
run: cargo doc --release --no-deps
|
|
|
|
- name: Build CLI binary
|
|
run: cargo build --release
|
|
|
|
- name: Upload CLI binary as artifact
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: Oxipng binary (${{ matrix.target }})
|
|
path: |
|
|
target/${{ env.CARGO_BUILD_TARGET }}/release/oxipng
|
|
target/${{ env.CARGO_BUILD_TARGET }}/release/oxipng.exe
|
|
|
|
msrv-check:
|
|
name: MSRV check
|
|
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
|
|
# Prevent tags and in-repo PRs from triggering this workflow more than once for a commit
|
|
if: github.ref_type != 'tag' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork)
|
|
|
|
steps:
|
|
- name: Checkout source
|
|
uses: actions/checkout@v3
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- name: Cache Cargo artifacts
|
|
uses: Swatinem/rust-cache@v2
|
|
|
|
- name: Install MSRV Rust toolchain
|
|
uses: dtolnay/rust-toolchain@1.65.0
|
|
|
|
- name: Install nextest
|
|
uses: taiki-e/install-action@nextest
|
|
|
|
- name: Run tests
|
|
run: |
|
|
cargo nextest run --release --features sanity-checks
|
|
cargo test --doc --release --features sanity-checks
|