* refactor(user): overhaul user data cleanup and export for cascading deletes and TTS segment support Revise user data cleanup logic to ensure proper cascading deletion of user-related database rows and S3 objects, including shared document and preview artifacts. Introduce explicit checks for last ownership before removing shared resources. Add TTS segment cache and audio cleanup to document and user deletion flows. Expand user data export to include TTS segment entries and audio, job events, document settings, and linked auth sessions. Update schema with ON DELETE CASCADE for userTtsChars and userJobEvents. Add new migration scripts and comprehensive unit tests for cleanup and export scenarios. * test(user): expand cleanup and export coverage for shared docs and TTS segment files Add tests for user data cleanup with shared document ownership and for TTS segment variant export scenarios, including cases with duplicate audio keys and storage disabled. Refactor cleanup logic to use document row types and transactional ownership removal with last-owner checks. Update TTS segment cache clearing to report deleted segment count by unique entry. Adjust export logic to always include all TTS segment variants and conditionally export file buckets based on storage availability. Update migration to use NOT VALID/VALIDATE for new cascading constraints. * refactor(documents): centralize owned document deletion and add mutation locking Introduce `deleteOwnedDocument` utility to encapsulate all logic for removing a user's ownership of a document, including TTS segment cache cleanup, preview artifact removal, and S3 blob deletion for last-owner cases. Add `withDocumentMutationLock` to serialize concurrent mutations on the same document, using advisory locks in Postgres and a local queue fallback. Refactor all API routes and user data flows to use these utilities, ensuring transactional safety and preventing race conditions during document deletion or transfer. Update tests for new flows and add coverage for document cleanup sequencing and locking behavior. * feat(data): enhance anonymous claim to support document settings and TTS segment copy Expand the anonymous data claim process to include document settings transfer and TTS segment S3 prefix copying. Remove foreign key constraints from user_tts_chars to allow non-user buckets. Update claim modal and onboarding flow to display claimed document settings. Refactor TTS char count transfer to merge all dates and fix upsert logic. Add S3 copy utility for TTS segments and corresponding tests. Update migrations and schema to reflect relaxed constraints. * refactor(data): improve error handling and rollback for document and TTS segment operations Enhance robustness of document deletion and TTS segment transfer by improving error logging, partial rollback, and degraded state reporting. Add best-effort cleanup and recovery mechanisms to prevent orphaned data and ensure diagnostic information is captured for unexpected failures. Update user data cleanup to log and swallow restoration errors without masking primary failures. Refine claim logic to handle unmapped TTS audio keys safely. * refactor(data): unify document mutation locking and transaction handling Replace mutation-lock with document-lock to centralize document mutation serialization and database transaction management. Introduce runInDbTransaction utility to abstract SQLite/Postgres transaction differences. Update document deletion, user data cleanup, and rate limiter logic to delegate transaction handling and locking to shared helpers. Remove dialect-specific branching and inline transaction logic for improved maintainability and testability. BREAKING CHANGE: withDocumentMutationLock is removed in favor of withDocumentLock and runInDbTransaction * fix(documents): improve rollback error handling in deleteOwnedDocument Enhance error handling during document deletion by ensuring that failures in restoring document ownership do not obscure the original error. Log degraded events when ownership restoration fails after a deletion error, providing additional context for debugging and monitoring. This change improves reliability and traceability of document deletion operations. * feat(tasks): introduce scheduled task engine and admin UI for background jobs Add a general-purpose scheduled task system with a persistent registry and status tracking, supporting background maintenance jobs such as orphaned blob reaping, expired upload cleanup, job event pruning, and TTS usage retention. Implement a new `scheduled_tasks` table, task engine, and handlers for each maintenance operation. Integrate an admin UI panel for monitoring, manual runs, and configuration of tasks. Update document and user data cleanup flows to delegate shared blob and preview deletion to the scheduled reaper. Add Vercel cron integration for serverless environments. BREAKING CHANGE: Document and user storage cleanup now relies on background scheduled tasks for shared blob and preview deletion; immediate inline deletion is no longer performed. * refactor(user): streamline document and TTS segment transfer logic Simplify user document transfer by consolidating storage and metadata handling. Remove inline deletion of shared blobs; only metadata is moved, and TTS segment transfer is controlled via options. Add `skipStorage` option for test scenarios to bypass storage operations. Update tests to reflect new transfer behavior. * chore(instrumentation): delegate node-specific setup to separate module Move Node.js-specific instrumentation logic to a dedicated file. Update registration to dynamically import the node module only when running in a Node.js environment. This separation clarifies environment-specific behavior and improves maintainability. * ci(config): update scheduled task cron to run daily at midnight Change cron schedule for /api/admin/tasks/tick from hourly to once daily at midnight to reduce task frequency and align with updated operational requirements. * refactor(tasks): enforce positive interval and improve scheduled task updates Add database-level check constraints to ensure scheduled task intervals are always positive for both Postgres and SQLite. Update admin API and UI to support sub-minute intervals and stricter validation. Refactor scheduled task update logic to upsert rows, ensuring tasks can be updated even if not yet present in the database. Improve temporary upload cleanup to delete in paginated batches. Enhance tests to cover new constraints and update behaviors. * chore(docker): remove ffmpeg-static from runtime dependencies in image build Eliminate ffmpeg-static from the production node_modules during Docker image assembly to streamline the deployment artifact and avoid bundling unused binaries. * refactor(admin): redesign task panel UI with Card layout and running indicator Replace the bordered div layout in AdminTasksPanel with the Card component for improved visual hierarchy. Add a dynamic running indicator using a custom RunningDot component to clearly show active tasks. Update control alignment and button states for better usability. Remove Badge-based status display in favor of a more streamlined appearance. * feat(tasks): add document blob lease for safe orphan reaping and improve scheduled task robustness Introduce a document blob lease mechanism to prevent race conditions between document registration and orphaned blob cleanup. The new `document_blob_leases` table ensures that only one process can claim a document blob for mutation or deletion at a time. Update the orphan reaper to acquire a lease before deleting blobs and to re-check for ownership after acquiring the lease, avoiding accidental deletion of in-flight uploads. Enhance scheduled task infrastructure with per-task fencing tokens to prevent stale runners from overwriting newer results, enforce runtime limits with abort signals, and expose scheduler mode and minimum interval to the admin panel and API. Adjust task handlers to accept a context with abort support, and update documentation and environment variable references for the new cron secret and scheduling behavior. BREAKING CHANGE: Scheduled tasks now require a `document_blob_leases` table and updated handler signatures. Vercel deployments must set `CRON_SECRET` for scheduled maintenance. * refactor(admin): add loading skeleton to tasks panel for improved UX Introduce a TasksSkeleton component to display animated placeholders while scheduled tasks are loading. Replace direct rendering of empty task rows with the skeleton when data is pending, enhancing perceived responsiveness and user experience in the admin tasks panel. * test: clean up playwright anonymous users * test: make blob lease expiry deterministic * fix(documents): improve blob lease release error handling and test stale lease scenario Handle errors during blob lease release by logging warnings instead of allowing them to mask original results. Update unit tests to verify that releasing a stale lease does not affect a replacement lease. * refactor(documents): implement exponential backoff with jitter for blob lease retries Replace fixed retry delay with capped exponential backoff and jitter to reduce contention and thundering herd effect when acquiring document blob leases. This improves lease acquisition fairness and efficiency under high load.
134 lines
4.6 KiB
TypeScript
134 lines
4.6 KiB
TypeScript
import { beforeEach, describe, expect, test, vi } from 'vitest';
|
|
|
|
const mocks = vi.hoisted(() => ({
|
|
selectResults: [] as unknown[][],
|
|
deleteWhere: vi.fn(async () => undefined),
|
|
deleteDocumentBlob: vi.fn(async () => undefined),
|
|
deleteDocumentPrefix: vi.fn(async () => 0),
|
|
deleteDocumentPreviewArtifacts: vi.fn(async () => 0),
|
|
deleteDocumentPreviewRows: vi.fn(async () => undefined),
|
|
deleteAudiobookPrefix: vi.fn(async () => 0),
|
|
deleteTtsSegmentPrefix: vi.fn(async () => 0),
|
|
}));
|
|
|
|
function resultBuilder(result: unknown[]) {
|
|
return {
|
|
then: (resolve: (value: unknown[]) => unknown, reject: (error: unknown) => unknown) =>
|
|
Promise.resolve(result).then(resolve, reject),
|
|
};
|
|
}
|
|
|
|
vi.mock('@/db', () => {
|
|
const database = {
|
|
select: vi.fn(() => ({
|
|
from: vi.fn(() => ({
|
|
where: vi.fn(() => resultBuilder(mocks.selectResults.shift() ?? [])),
|
|
})),
|
|
})),
|
|
delete: vi.fn(() => ({
|
|
where: vi.fn(() => {
|
|
const promise = mocks.deleteWhere();
|
|
return {
|
|
then: promise.then.bind(promise),
|
|
catch: promise.catch.bind(promise),
|
|
};
|
|
}),
|
|
})),
|
|
};
|
|
return { db: database };
|
|
});
|
|
|
|
vi.mock('@/lib/server/storage/s3', () => ({
|
|
isS3Configured: () => true,
|
|
getS3Config: () => ({ prefix: 'openreader-test' }),
|
|
}));
|
|
|
|
vi.mock('@/lib/server/documents/blobstore', () => ({
|
|
deleteDocumentBlob: mocks.deleteDocumentBlob,
|
|
deleteDocumentPrefix: mocks.deleteDocumentPrefix,
|
|
tempDocumentUploadPrefix: () => 'temp/user/',
|
|
}));
|
|
|
|
vi.mock('@/lib/server/documents/previews-blobstore', () => ({
|
|
deleteDocumentPreviewArtifacts: mocks.deleteDocumentPreviewArtifacts,
|
|
}));
|
|
|
|
vi.mock('@/lib/server/documents/previews', () => ({
|
|
deleteDocumentPreviewRows: mocks.deleteDocumentPreviewRows,
|
|
}));
|
|
|
|
vi.mock('@/lib/server/audiobooks/blobstore', () => ({
|
|
audiobookPrefix: () => 'audiobooks/user/',
|
|
deleteAudiobookPrefix: mocks.deleteAudiobookPrefix,
|
|
}));
|
|
|
|
vi.mock('@/lib/server/tts/segments-blobstore', () => ({
|
|
deleteTtsSegmentPrefix: mocks.deleteTtsSegmentPrefix,
|
|
}));
|
|
|
|
vi.mock('@/lib/server/logger', () => ({
|
|
hashForLog: () => 'hash',
|
|
serverLogger: { info: vi.fn(), warn: vi.fn(), error: vi.fn() },
|
|
}));
|
|
|
|
vi.mock('@/lib/server/errors/logging', () => ({
|
|
logDegraded: vi.fn(),
|
|
}));
|
|
|
|
import { deleteUserStorageData } from '../../src/lib/server/user/data-cleanup';
|
|
|
|
describe('user data cleanup', () => {
|
|
beforeEach(() => {
|
|
mocks.selectResults = [];
|
|
for (const mock of Object.values(mocks)) {
|
|
if (typeof mock === 'function' && 'mockReset' in mock) {
|
|
mock.mockReset();
|
|
}
|
|
}
|
|
mocks.deleteWhere.mockResolvedValue(undefined);
|
|
mocks.deleteDocumentBlob.mockResolvedValue(undefined);
|
|
mocks.deleteDocumentPrefix.mockResolvedValue(0);
|
|
mocks.deleteDocumentPreviewArtifacts.mockResolvedValue(0);
|
|
mocks.deleteDocumentPreviewRows.mockResolvedValue(undefined);
|
|
mocks.deleteAudiobookPrefix.mockResolvedValue(0);
|
|
mocks.deleteTtsSegmentPrefix.mockResolvedValue(0);
|
|
});
|
|
|
|
test('defers document blobs/previews to the reaper on the canonical pass', async () => {
|
|
mocks.selectResults = [[]]; // no audiobooks
|
|
|
|
await deleteUserStorageData('user-1', null);
|
|
|
|
// Shared document storage is reclaimed by the reap-orphaned-blobs task, not here.
|
|
expect(mocks.deleteDocumentBlob).not.toHaveBeenCalled();
|
|
expect(mocks.deleteDocumentPreviewArtifacts).not.toHaveBeenCalled();
|
|
expect(mocks.deleteDocumentPreviewRows).not.toHaveBeenCalled();
|
|
// Only the three non-cascading DB row deletes (tts usage, job events, verification).
|
|
expect(mocks.deleteWhere).toHaveBeenCalledTimes(3);
|
|
});
|
|
|
|
test('blocks database cleanup when storage cleanup fails', async () => {
|
|
mocks.selectResults = [[]]; // no audiobooks
|
|
mocks.deleteDocumentPrefix.mockRejectedValueOnce(new Error('storage unavailable'));
|
|
|
|
await expect(deleteUserStorageData('user-1', null)).rejects.toThrow(
|
|
'User storage cleanup failed',
|
|
);
|
|
expect(mocks.deleteWhere).not.toHaveBeenCalled();
|
|
});
|
|
|
|
test('deletes namespaced document storage inline and skips global DB rows', async () => {
|
|
mocks.selectResults = [
|
|
[{ id: 'doc-1' }], // userDocs (namespaced pass)
|
|
[], // audiobooks
|
|
];
|
|
|
|
await deleteUserStorageData('user-1', 'test-ns');
|
|
|
|
expect(mocks.deleteDocumentBlob).toHaveBeenCalledWith('doc-1', 'test-ns');
|
|
expect(mocks.deleteDocumentPreviewArtifacts).toHaveBeenCalledWith('doc-1', 'test-ns');
|
|
expect(mocks.deleteDocumentPreviewRows).toHaveBeenCalledWith('doc-1', 'test-ns');
|
|
// Global DB rows are only removed on the canonical pass.
|
|
expect(mocks.deleteWhere).not.toHaveBeenCalled();
|
|
});
|
|
});
|