danvics/howdy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove dismiss_lockscreen config option

Browse source
This commit is contained in:
boltgolt 2019-03-29 22:21:14 +01:00
parent fd300e52e3
commit 8537366154
No known key found for this signature in database
GPG key ID: BECEC9937E1AAE26
3 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
debian/postinst vendored
View file

@ -70,6 +70,13 @@ if not os.path.exists("/tmp/howdy_picked_device"):
if key == "timout": if key == "timout":
key = "timeout" key = "timeout"
# MIGRATION 2.5.0 -> 2.5.1
# Remove unsafe automatic dismissal of lock screen
if key == "dismiss_lockscreen":
if (value == "true"):
print("DEPRECATION: Config falue dismiss_lockscreen is no longer supported because of login loop issues.")
continue
try: try:
newConf.set(section, key, value) newConf.set(section, key, value)
# Add a new section where needed # Add a new section where needed

5
src/config.ini
View file

@ -18,11 +18,6 @@ ignore_ssh = true
# Disable Howdy if lid is closed # Disable Howdy if lid is closed
ignore_closed_lid = true ignore_closed_lid = true
# Auto dismiss lock screen on confirmation
# Will run loginctl unlock-sessions after every auth
# Experimental, can behave incorrectly on some systems
dismiss_lockscreen = false
# Disable howdy in the PAM # Disable howdy in the PAM
# The howdy command will still function # The howdy command will still function
disabled = false disabled = false

5
src/pam.py
View file

@ -56,11 +56,6 @@ def doAuth(pamh):
if not config.getboolean("core", "no_confirmation", fallback=False): if not config.getboolean("core", "no_confirmation", fallback=False):
pamh.conversation(pamh.Message(pamh.PAM_TEXT_INFO, "Identified face as " + pamh.get_user())) pamh.conversation(pamh.Message(pamh.PAM_TEXT_INFO, "Identified face as " + pamh.get_user()))
# Try to dismiss the lock screen if enabled
if config.getboolean("core", "dismiss_lockscreen", fallback=False):
# Run it as root with a timeout of 1s, and never ask for a password through the UI
subprocess.Popen(["sudo", "timeout", "1", "loginctl", "unlock-sessions", "--no-ask-password"])
return pamh.PAM_SUCCESS return pamh.PAM_SUCCESS
# Otherwise, we can't discribe what happend but it wasn't successful # Otherwise, we can't discribe what happend but it wasn't successful