Closes the 12 MAJ raised by the release/0.5.0 audit pipeline (cf.
docs/audit/reports/release-0.5.0/summary.md → summary-reaudit.md).
Volet 1 — Reasoning architecture (audits 01/02/06/07 strengthening)
* Domain ports: LLMProvider, ReasoningRunner, ReasoningParseError
* Domain DTOs: LLMProviderType, ReasoningResult, ReasoningIteration
* infra/llm/ollama_provider.py — OllamaProvider with health_check
* infra/docling_agent_reasoning.py — runner adapter, encapsulates the
private _rag_loop call (tracked at docling-project/docling-agent#26),
commits OLLAMA_HOST once at boot (eliminates the per-request env race),
translates upstream IndexError into ReasoningParseError
* api/reasoning.py — zero coupling to docling-agent / mellea / docling-core,
consumes app.state.reasoning_runner via the port
* main.py — DI wires OllamaProvider + DoclingAgentReasoningRunner at boot
when REASONING_ENABLED=true and deps are importable
* Rename RAG_* env vars → REASONING_*, endpoint /rag → /reasoning,
type RAGResult → ReasoningResult, frontend feature flag wiring,
i18n strings, tests, docs (BREAKING — pre-1.0 surface, no external
consumers in production)
* 17 new tests: adapter unit tests with sys.modules stubs, OllamaProvider
httpx tests, R3 concurrent-host isolation, R6 multi-iteration trace
serialization, R13 Protocol conformance via isinstance
* E2E Karate scenario: nav-reasoning hidden when REASONING_ENABLED=false
* README — Live Reasoning section (env vars, archi, link to issue #26)
Bloc B — Security (audit 08, dev-only context)
* docker-compose.yml — DEV DEFAULTS header, OpenSearch DISABLE_SECURITY_PLUGIN
flagged as dev-only with link to OpenSearch security docs
* main.py — boot warning if NEO4J_URI is set with the default 'changeme'
password, so prod operators can't silently inherit it
Bloc C — DRY frontend (audit 05)
* shared/storage/keys.ts — STORAGE_KEYS centralised (theme, locale)
* features/settings/store.ts — dead apiUrl ref + orphan i18n keys removed
* api/schemas.py — DOCUMENT_STATUS_UPLOADED constant
Bloc D — Quality (audits 02/06/07/09/10/12)
* domain/ports.py — DocumentConverter.supports_page_batching property
(LSP fix, replaces isinstance(ServeConverter) check)
* domain/ports.py — VectorStore.ping() (encapsulation, replaces
_vector_store._client.info() reach-around)
* api/analyses.py + api/ingestion.py — path params {job_id} → {analysis_id}
aligned with the user-facing terminology (URLs unchanged)
* api/documents.py — Path.read_bytes() + generate_preview() wrapped in
asyncio.to_thread, unblocks the FastAPI event loop on /preview
* infra/docling_tree.py — PEP 604 union for isinstance (Ruff UP038)
* src/__tests__/integration/ — cross-feature integration test relocated
out of features/history/ so feature folders stay self-contained
* Tightened terminal `assert X is not None` checks (isinstance(.., datetime),
exact value comparisons)
Validation
* 446 backend pytest, 202 frontend vitest — all green
* ruff + ruff format + ESLint + Prettier + vue-tsc clean
* Re-audit verdict: 0 CRIT / 0 MAJ, score ~94/100, GO
Closes #200
165 lines
5.6 KiB
Python
165 lines
5.6 KiB
Python
"""Analysis API router — create, list, get, delete analysis jobs."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
from typing import Annotated
|
|
|
|
from fastapi import APIRouter, Depends, HTTPException, Request
|
|
|
|
from api.schemas import (
|
|
AnalysisResponse,
|
|
ChunkBboxResponse,
|
|
ChunkResponse,
|
|
CreateAnalysisRequest,
|
|
RechunkRequest,
|
|
UpdateChunkTextRequest,
|
|
)
|
|
from services.analysis_service import AnalysisService
|
|
|
|
logger = logging.getLogger(__name__)
|
|
router = APIRouter(prefix="/api/analyses", tags=["analyses"])
|
|
|
|
|
|
def _get_service(request: Request) -> AnalysisService:
|
|
return request.app.state.analysis_service
|
|
|
|
|
|
ServiceDep = Annotated[AnalysisService, Depends(_get_service)]
|
|
|
|
|
|
def _to_response(job) -> AnalysisResponse:
|
|
return AnalysisResponse(
|
|
id=job.id,
|
|
document_id=job.document_id,
|
|
document_filename=job.document_filename,
|
|
status=job.status.value,
|
|
content_markdown=job.content_markdown,
|
|
content_html=job.content_html,
|
|
pages_json=job.pages_json,
|
|
chunks_json=job.chunks_json,
|
|
has_document_json=job.document_json is not None,
|
|
error_message=job.error_message,
|
|
progress_current=job.progress_current,
|
|
progress_total=job.progress_total,
|
|
started_at=str(job.started_at) if job.started_at else None,
|
|
completed_at=str(job.completed_at) if job.completed_at else None,
|
|
created_at=str(job.created_at),
|
|
)
|
|
|
|
|
|
@router.post("", response_model=AnalysisResponse)
|
|
async def create_analysis(body: CreateAnalysisRequest, service: ServiceDep) -> AnalysisResponse:
|
|
"""Create a new analysis job for a document."""
|
|
if not body.documentId or not body.documentId.strip():
|
|
raise HTTPException(status_code=400, detail="documentId is required")
|
|
|
|
pipeline_opts = None
|
|
if body.pipelineOptions:
|
|
pipeline_opts = body.pipelineOptions.model_dump()
|
|
|
|
chunking_opts = None
|
|
if body.chunkingOptions:
|
|
chunking_opts = body.chunkingOptions.model_dump()
|
|
|
|
try:
|
|
job = await service.create(
|
|
body.documentId,
|
|
pipeline_options=pipeline_opts,
|
|
chunking_options=chunking_opts,
|
|
)
|
|
except ValueError as e:
|
|
raise HTTPException(status_code=404, detail=str(e)) from e
|
|
|
|
return _to_response(job)
|
|
|
|
|
|
@router.get("", response_model=list[AnalysisResponse])
|
|
async def list_analyses(service: ServiceDep) -> list[AnalysisResponse]:
|
|
"""List all analysis jobs."""
|
|
jobs = await service.find_all()
|
|
return [_to_response(j) for j in jobs]
|
|
|
|
|
|
@router.get("/{analysis_id}", response_model=AnalysisResponse)
|
|
async def get_analysis(analysis_id: str, service: ServiceDep) -> AnalysisResponse:
|
|
"""Get a single analysis job."""
|
|
job = await service.find_by_id(analysis_id)
|
|
if not job:
|
|
raise HTTPException(status_code=404, detail="Analysis not found")
|
|
return _to_response(job)
|
|
|
|
|
|
@router.post("/{analysis_id}/rechunk", response_model=list[ChunkResponse])
|
|
async def rechunk_analysis(
|
|
analysis_id: str, body: RechunkRequest, service: ServiceDep
|
|
) -> list[ChunkResponse]:
|
|
"""Re-chunk a completed analysis with new chunking options."""
|
|
try:
|
|
chunks = await service.rechunk(analysis_id, body.chunkingOptions.model_dump())
|
|
except ValueError as e:
|
|
raise HTTPException(status_code=400, detail=str(e)) from e
|
|
return [
|
|
ChunkResponse(
|
|
text=c.text,
|
|
headings=c.headings,
|
|
source_page=c.source_page,
|
|
token_count=c.token_count,
|
|
bboxes=[ChunkBboxResponse(page=b.page, bbox=b.bbox) for b in c.bboxes],
|
|
)
|
|
for c in chunks
|
|
]
|
|
|
|
|
|
@router.patch("/{analysis_id}/chunks/{chunk_index}", response_model=list[ChunkResponse])
|
|
async def update_chunk_text(
|
|
analysis_id: str, chunk_index: int, body: UpdateChunkTextRequest, service: ServiceDep
|
|
) -> list[ChunkResponse]:
|
|
"""Update the text of a single chunk by index."""
|
|
try:
|
|
chunks = await service.update_chunk_text(analysis_id, chunk_index, body.text)
|
|
except ValueError as e:
|
|
raise HTTPException(status_code=400, detail=str(e)) from e
|
|
return [
|
|
ChunkResponse(
|
|
text=c["text"],
|
|
headings=c.get("headings", []),
|
|
source_page=c.get("sourcePage"),
|
|
token_count=c.get("tokenCount", 0),
|
|
bboxes=[ChunkBboxResponse(page=b["page"], bbox=b["bbox"]) for b in c.get("bboxes", [])],
|
|
modified=c.get("modified", False),
|
|
deleted=c.get("deleted", False),
|
|
)
|
|
for c in chunks
|
|
]
|
|
|
|
|
|
@router.delete("/{analysis_id}/chunks/{chunk_index}", response_model=list[ChunkResponse])
|
|
async def delete_chunk(
|
|
analysis_id: str, chunk_index: int, service: ServiceDep
|
|
) -> list[ChunkResponse]:
|
|
"""Soft-delete a chunk by index (marks it as deleted)."""
|
|
try:
|
|
chunks = await service.delete_chunk(analysis_id, chunk_index)
|
|
except ValueError as e:
|
|
raise HTTPException(status_code=400, detail=str(e)) from e
|
|
return [
|
|
ChunkResponse(
|
|
text=c["text"],
|
|
headings=c.get("headings", []),
|
|
source_page=c.get("sourcePage"),
|
|
token_count=c.get("tokenCount", 0),
|
|
bboxes=[ChunkBboxResponse(page=b["page"], bbox=b["bbox"]) for b in c.get("bboxes", [])],
|
|
modified=c.get("modified", False),
|
|
deleted=c.get("deleted", False),
|
|
)
|
|
for c in chunks
|
|
]
|
|
|
|
|
|
@router.delete("/{analysis_id}", status_code=204, response_model=None)
|
|
async def delete_analysis(analysis_id: str, service: ServiceDep) -> None:
|
|
"""Delete an analysis job."""
|
|
deleted = await service.delete(analysis_id)
|
|
if not deleted:
|
|
raise HTTPException(status_code=404, detail="Analysis not found")
|