8ae9dcdc04
Closes the 12 MAJ raised by the release/0.5.0 audit pipeline (cf.
docs/audit/reports/release-0.5.0/summary.md → summary-reaudit.md).
Volet 1 — Reasoning architecture (audits 01/02/06/07 strengthening)
* Domain ports: LLMProvider, ReasoningRunner, ReasoningParseError
* Domain DTOs: LLMProviderType, ReasoningResult, ReasoningIteration
* infra/llm/ollama_provider.py — OllamaProvider with health_check
* infra/docling_agent_reasoning.py — runner adapter, encapsulates the
private _rag_loop call (tracked at docling-project/docling-agent#26),
commits OLLAMA_HOST once at boot (eliminates the per-request env race),
translates upstream IndexError into ReasoningParseError
* api/reasoning.py — zero coupling to docling-agent / mellea / docling-core,
consumes app.state.reasoning_runner via the port
* main.py — DI wires OllamaProvider + DoclingAgentReasoningRunner at boot
when REASONING_ENABLED=true and deps are importable
* Rename RAG_* env vars → REASONING_*, endpoint /rag → /reasoning,
type RAGResult → ReasoningResult, frontend feature flag wiring,
i18n strings, tests, docs (BREAKING — pre-1.0 surface, no external
consumers in production)
* 17 new tests: adapter unit tests with sys.modules stubs, OllamaProvider
httpx tests, R3 concurrent-host isolation, R6 multi-iteration trace
serialization, R13 Protocol conformance via isinstance
* E2E Karate scenario: nav-reasoning hidden when REASONING_ENABLED=false
* README — Live Reasoning section (env vars, archi, link to issue #26)
Bloc B — Security (audit 08, dev-only context)
* docker-compose.yml — DEV DEFAULTS header, OpenSearch DISABLE_SECURITY_PLUGIN
flagged as dev-only with link to OpenSearch security docs
* main.py — boot warning if NEO4J_URI is set with the default 'changeme'
password, so prod operators can't silently inherit it
Bloc C — DRY frontend (audit 05)
* shared/storage/keys.ts — STORAGE_KEYS centralised (theme, locale)
* features/settings/store.ts — dead apiUrl ref + orphan i18n keys removed
* api/schemas.py — DOCUMENT_STATUS_UPLOADED constant
Bloc D — Quality (audits 02/06/07/09/10/12)
* domain/ports.py — DocumentConverter.supports_page_batching property
(LSP fix, replaces isinstance(ServeConverter) check)
* domain/ports.py — VectorStore.ping() (encapsulation, replaces
_vector_store._client.info() reach-around)
* api/analyses.py + api/ingestion.py — path params {job_id} → {analysis_id}
aligned with the user-facing terminology (URLs unchanged)
* api/documents.py — Path.read_bytes() + generate_preview() wrapped in
asyncio.to_thread, unblocks the FastAPI event loop on /preview
* infra/docling_tree.py — PEP 604 union for isinstance (Ruff UP038)
* src/__tests__/integration/ — cross-feature integration test relocated
out of features/history/ so feature folders stay self-contained
* Tightened terminal `assert X is not None` checks (isinstance(.., datetime),
exact value comparisons)
Validation
* 446 backend pytest, 202 frontend vitest — all green
* ruff + ruff format + ESLint + Prettier + vue-tsc clean
* Re-audit verdict: 0 CRIT / 0 MAJ, score ~94/100, GO
Closes #200
34 lines
1.4 KiB
Gherkin
34 lines
1.4 KiB
Gherkin
@ui
|
|
Feature: UI — Reasoning feature flag
|
|
|
|
# The Reasoning sidebar entry must be hidden when the backend is not wired
|
|
# to expose the live runner. This test runs against the default CI backend
|
|
# (REASONING_ENABLED unset → false), so `reasoningAvailable` from
|
|
# /api/health is false and the sidebar entry must not render.
|
|
#
|
|
# When REASONING_ENABLED=true on the backend with docling-agent installed,
|
|
# this scenario will fail — flip the assertion or drop the @reasoning-off
|
|
# tag in CI accordingly.
|
|
|
|
@reasoning-off
|
|
Scenario: Sidebar does not show Reasoning when the runner isn't wired
|
|
* driver uiBaseUrl
|
|
* waitFor('[data-e2e=sidebar]')
|
|
|
|
# The other nav items must still render
|
|
* waitFor('[data-e2e=nav-studio]')
|
|
* waitFor('[data-e2e=nav-documents]')
|
|
|
|
# nav-reasoning must NOT be present (v-if="reasoningEnabled" gates it on
|
|
# `reasoningAvailable` in the health response)
|
|
* match karate.sizeOf(locateAll('[data-e2e=nav-reasoning]')) == 0
|
|
|
|
@reasoning-off
|
|
Scenario: /reasoning route is reachable but flag-driven UI gates the entry point
|
|
* driver uiBaseUrl + '/reasoning'
|
|
|
|
# The route is registered in the SPA router so a deep-link doesn't 404,
|
|
# but the sidebar nav-reasoning entry stays hidden — users can't reach
|
|
# the page through normal navigation when the runner is disabled.
|
|
* waitFor('[data-e2e=sidebar]')
|
|
* match karate.sizeOf(locateAll('[data-e2e=nav-reasoning]')) == 0
|