Closes the 12 MAJ raised by the release/0.5.0 audit pipeline (cf.
docs/audit/reports/release-0.5.0/summary.md → summary-reaudit.md).
Volet 1 — Reasoning architecture (audits 01/02/06/07 strengthening)
* Domain ports: LLMProvider, ReasoningRunner, ReasoningParseError
* Domain DTOs: LLMProviderType, ReasoningResult, ReasoningIteration
* infra/llm/ollama_provider.py — OllamaProvider with health_check
* infra/docling_agent_reasoning.py — runner adapter, encapsulates the
private _rag_loop call (tracked at docling-project/docling-agent#26),
commits OLLAMA_HOST once at boot (eliminates the per-request env race),
translates upstream IndexError into ReasoningParseError
* api/reasoning.py — zero coupling to docling-agent / mellea / docling-core,
consumes app.state.reasoning_runner via the port
* main.py — DI wires OllamaProvider + DoclingAgentReasoningRunner at boot
when REASONING_ENABLED=true and deps are importable
* Rename RAG_* env vars → REASONING_*, endpoint /rag → /reasoning,
type RAGResult → ReasoningResult, frontend feature flag wiring,
i18n strings, tests, docs (BREAKING — pre-1.0 surface, no external
consumers in production)
* 17 new tests: adapter unit tests with sys.modules stubs, OllamaProvider
httpx tests, R3 concurrent-host isolation, R6 multi-iteration trace
serialization, R13 Protocol conformance via isinstance
* E2E Karate scenario: nav-reasoning hidden when REASONING_ENABLED=false
* README — Live Reasoning section (env vars, archi, link to issue #26)
Bloc B — Security (audit 08, dev-only context)
* docker-compose.yml — DEV DEFAULTS header, OpenSearch DISABLE_SECURITY_PLUGIN
flagged as dev-only with link to OpenSearch security docs
* main.py — boot warning if NEO4J_URI is set with the default 'changeme'
password, so prod operators can't silently inherit it
Bloc C — DRY frontend (audit 05)
* shared/storage/keys.ts — STORAGE_KEYS centralised (theme, locale)
* features/settings/store.ts — dead apiUrl ref + orphan i18n keys removed
* api/schemas.py — DOCUMENT_STATUS_UPLOADED constant
Bloc D — Quality (audits 02/06/07/09/10/12)
* domain/ports.py — DocumentConverter.supports_page_batching property
(LSP fix, replaces isinstance(ServeConverter) check)
* domain/ports.py — VectorStore.ping() (encapsulation, replaces
_vector_store._client.info() reach-around)
* api/analyses.py + api/ingestion.py — path params {job_id} → {analysis_id}
aligned with the user-facing terminology (URLs unchanged)
* api/documents.py — Path.read_bytes() + generate_preview() wrapped in
asyncio.to_thread, unblocks the FastAPI event loop on /preview
* infra/docling_tree.py — PEP 604 union for isinstance (Ruff UP038)
* src/__tests__/integration/ — cross-feature integration test relocated
out of features/history/ so feature folders stay self-contained
* Tightened terminal `assert X is not None` checks (isinstance(.., datetime),
exact value comparisons)
Validation
* 446 backend pytest, 202 frontend vitest — all green
* ruff + ruff format + ESLint + Prettier + vue-tsc clean
* Re-audit verdict: 0 CRIT / 0 MAJ, score ~94/100, GO
Closes #200
139 lines
3.9 KiB
Python
139 lines
3.9 KiB
Python
"""Domain value objects — pure data structures for document conversion.
|
|
|
|
These types define the contract between the domain and infrastructure layers.
|
|
They have ZERO external dependencies (no docling, no HTTP, no DB).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from dataclasses import dataclass, field
|
|
from enum import StrEnum
|
|
|
|
# US Letter page dimensions (points) — fallback when page size is unknown
|
|
DEFAULT_PAGE_WIDTH: float = 612.0
|
|
DEFAULT_PAGE_HEIGHT: float = 792.0
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class PageElement:
|
|
type: str
|
|
bbox: list[float]
|
|
content: str
|
|
level: int = 0
|
|
# Docling `self_ref` ("#/texts/12", "#/tables/3", …). Empty for items
|
|
# that don't have one (rare — defensive default). Lets callers correlate
|
|
# a rendered bbox with the corresponding node in the graph without
|
|
# resorting to fuzzy bbox matching.
|
|
self_ref: str = ""
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class PageDetail:
|
|
page_number: int
|
|
width: float
|
|
height: float
|
|
elements: list[PageElement] = field(default_factory=list)
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class ConversionOptions:
|
|
do_ocr: bool = True
|
|
do_table_structure: bool = True
|
|
table_mode: str = "accurate"
|
|
do_code_enrichment: bool = False
|
|
do_formula_enrichment: bool = False
|
|
do_picture_classification: bool = False
|
|
do_picture_description: bool = False
|
|
generate_picture_images: bool = False
|
|
generate_page_images: bool = False
|
|
images_scale: float = 1.0
|
|
|
|
def is_default(self) -> bool:
|
|
"""Return True if all options match their defaults."""
|
|
return self == ConversionOptions()
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class ConversionResult:
|
|
page_count: int
|
|
content_markdown: str
|
|
content_html: str
|
|
pages: list[PageDetail]
|
|
skipped_items: int = 0
|
|
document_json: str | None = None
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class ChunkingOptions:
|
|
chunker_type: str = "hybrid" # "hybrid", "hierarchical", "page"
|
|
max_tokens: int = 512
|
|
merge_peers: bool = True
|
|
repeat_table_header: bool = True
|
|
|
|
def is_default(self) -> bool:
|
|
"""Return True if all options match their defaults."""
|
|
return self == ChunkingOptions()
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class ChunkBbox:
|
|
page: int
|
|
bbox: list[float] # [left, top, right, bottom] in TOPLEFT origin
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class ChunkDocItem:
|
|
"""Source element referenced by a chunk. Enables Neo4j DERIVED_FROM edges."""
|
|
|
|
self_ref: str
|
|
label: str
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class ChunkResult:
|
|
text: str
|
|
headings: list[str] = field(default_factory=list)
|
|
source_page: int | None = None
|
|
token_count: int = 0
|
|
bboxes: list[ChunkBbox] = field(default_factory=list)
|
|
doc_items: list[ChunkDocItem] = field(default_factory=list)
|
|
|
|
|
|
# --- Reasoning (live docling-agent runner) -----------------------------------
|
|
|
|
|
|
class LLMProviderType(StrEnum):
|
|
"""LLM backends the reasoning runner can talk to.
|
|
|
|
Today only OLLAMA is realizable: docling-agent v0.1.0 is hardwired to
|
|
Ollama via mellea's `setup_local_session`. Other variants are kept here
|
|
to make the abstraction visible and prepare future backends — adding one
|
|
requires either docling-agent upstream support (see
|
|
https://github.com/docling-project/docling-agent/issues/26) or a fork.
|
|
"""
|
|
|
|
OLLAMA = "ollama"
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class ReasoningIteration:
|
|
"""One step of the reasoning loop — section the agent visited and what
|
|
it concluded. Mirrors the upstream docling-agent `RAGIteration` shape so
|
|
serialization stays 1:1 with externally-produced traces."""
|
|
|
|
iteration: int
|
|
section_ref: str
|
|
reason: str
|
|
section_text_length: int
|
|
can_answer: bool
|
|
response: str
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class ReasoningResult:
|
|
"""Full output of a reasoning run: final answer, the path the agent
|
|
walked through the document, and whether the loop converged."""
|
|
|
|
answer: str
|
|
iterations: list[ReasoningIteration]
|
|
converged: bool
|