danvics/docling-studio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: remove dead store and no-effect await flagged by CodeQL

Browse source 
- local_converter.py: remove redundant `_default_converter = None` in
  except block of `_ensure_default_converter` (variable was already None,
  re-raised immediately — dead store)
- test_analysis_service.py: replace bare `await task` with
  `await asyncio.gather(task)` to satisfy static analysis
This commit is contained in:
Pier-Jean Malandrino 2026-04-10 14:37:51 +02:00
parent 6d0c4dd192
commit d8937ad916
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
document-parser/infra/local_converter.py
View file

@ -120,7 +120,6 @@ def _ensure_default_converter() -> DoclingConverter:
try: try:
_default_converter = _build_docling_converter(ConversionOptions()) _default_converter = _build_docling_converter(ConversionOptions())
except Exception: except Exception:
_default_converter = None
raise raise
return _default_converter return _default_converter

2
document-parser/tests/test_analysis_service.py
View file

@ -152,7 +152,7 @@ class TestAnalysisServiceCancellation:
task = asyncio.create_task(instant()) task = asyncio.create_task(instant())
service._running_tasks["j1"] = task service._running_tasks["j1"] = task
task.add_done_callback(functools.partial(service._on_task_done, job_id="j1")) task.add_done_callback(functools.partial(service._on_task_done, job_id="j1"))
await task await asyncio.gather(task)
assert "j1" not in service._running_tasks assert "j1" not in service._running_tasks