From a54441f679dcba68e3be5517035d16a7cdc9bafc Mon Sep 17 00:00:00 2001
From: Super12138 <70494801+Super12138@users.noreply.github.com>
Date: Sat, 7 Sep 2024 16:55:21 +0800
Subject: [PATCH] Improve about activity

---
 app/src/main/res/layout/activity_about.xml | 47 +++++++++-------------
 1 file changed, 19 insertions(+), 28 deletions(-)

diff --git a/app/src/main/res/layout/activity_about.xml b/app/src/main/res/layout/activity_about.xml
index e1c0cf9..cfc91c7 100644
--- a/app/src/main/res/layout/activity_about.xml
+++ b/app/src/main/res/layout/activity_about.xml
@@ -50,19 +50,26 @@
                         android:id="@+id/app_info"
                         android:layout_width="match_parent"
                         android:layout_height="wrap_content"
+                        android:gravity="center_horizontal"
                         android:orientation="vertical">
 
-                        <ImageView
-                            android:id="@+id/app_icon"
+                        <com.google.android.material.card.MaterialCardView
+                            style="@style/Widget.Material3.CardView.Elevated"
                             android:layout_width="wrap_content"
                             android:layout_height="wrap_content"
-                            android:layout_gravity="center_horizontal"
-                            android:contentDescription="@string/app_name"
-                            app:srcCompat="@drawable/ic_launcher" />
+                            app:cardCornerRadius="128dp">
+
+                            <ImageView
+                                android:layout_width="wrap_content"
+                                android:layout_height="wrap_content"
+                                android:layout_gravity="center"
+                                android:contentDescription="@string/app_name"
+                                android:src="@mipmap/ic_launcher" />
+                        </com.google.android.material.card.MaterialCardView>
 
                         <TextView
                             android:id="@+id/app_name"
-                            android:layout_width="match_parent"
+                            android:layout_width="wrap_content"
                             android:layout_height="wrap_content"
                             android:layout_marginTop="10dp"
                             android:text="@string/app_name"
@@ -72,7 +79,7 @@
 
                         <TextView
                             android:id="@+id/app_version"
-                            android:layout_width="match_parent"
+                            android:layout_width="wrap_content"
                             android:layout_height="wrap_content"
                             android:layout_marginTop="7dp"
                             android:textAlignment="center"
@@ -87,7 +94,7 @@
                         android:background="?attr/selectableItemBackground"
                         android:clickable="true"
                         android:focusable="true"
-                        android:gravity="center_horizontal|center_vertical"
+                        android:gravity="center"
                         android:orientation="horizontal">
 
                         <ImageView
@@ -95,6 +102,7 @@
                             android:layout_width="wrap_content"
                             android:layout_height="wrap_content"
                             android:layout_marginStart="15dp"
+                            android:contentDescription="@string/check_update"
                             app:srcCompat="@drawable/ic_update" />
 
                         <TextView
@@ -114,7 +122,7 @@
                         android:background="?attr/selectableItemBackground"
                         android:clickable="true"
                         android:focusable="true"
-                        android:gravity="center_horizontal|center_vertical"
+                        android:gravity="center"
                         android:orientation="horizontal">
 
                         <ImageView
@@ -122,6 +130,7 @@
                             android:layout_width="wrap_content"
                             android:layout_height="wrap_content"
                             android:layout_marginStart="15dp"
+                            android:contentDescription="@string/view_source"
                             app:srcCompat="@drawable/ic_github" />
 
                         <TextView
@@ -149,6 +158,7 @@
                             android:layout_width="wrap_content"
                             android:layout_height="wrap_content"
                             android:layout_marginStart="15dp"
+                            android:contentDescription="@string/author"
                             app:srcCompat="@drawable/ic_person" />
 
                         <TextView
@@ -160,25 +170,6 @@
                             android:textColor="?attr/colorOnSurface"
                             android:textSize="15sp" />
                     </LinearLayout>
-
-                    <!--<LinearLayout
-                        android:id="@+id/wrp"
-                        android:layout_width="match_parent"
-                        android:layout_height="30dp"
-                        android:layout_marginTop="30dp"
-                        android:layout_marginBottom="20dp"
-                        android:gravity="center_horizontal|center_vertical"
-                        android:orientation="horizontal">
-
-                        <ImageView
-                            android:id="@+id/wrp_icon"
-                            android:layout_width="wrap_content"
-                            android:layout_height="wrap_content"
-                            android:layout_gravity="center_horizontal"
-                            android:layout_marginStart="15dp"
-                            app:srcCompat="@drawable/wrp_24" />
-                    </LinearLayout>-->
-
                 </LinearLayout>
             </com.google.android.material.card.MaterialCardView>
         </LinearLayout>