danvics/R710-Fan-Control
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Protect against divide by zero, plus have a die handler anyway that makes sure fans reset back to default control

Browse source
This commit is contained in:
Tim Connors 2019-12-29 17:45:13 +11:00
parent 5b513155ff
commit ead6ea755a
1 changed files with 37 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
R710-IPMI-TEMP/fan-speed-control.pl
View file

@ -36,23 +36,30 @@ my $lastfan;
sub average { sub average {
my (@temps) = (@_); my (@temps) = (@_);
my $div = @temps; my $div = 0;
my $tot = 0; my $tot = 0;
for (my $i = 0; $i < @temps ; $i++) { for (my $i = 0; $i < @temps ; $i++) {
$tot += $temps[$i]; if (defined $temps[$i]) {
$tot += $temps[$i];
$div++;
}
}
my $avg=undef;
if ($div > 0) {
$avg = sprintf "%.2f", $tot/$div;
} }
my $avg = sprintf "%.2f", $tot/$div;
return $avg; return $avg;
} }
sub max { sub max {
my ($v1, $v2) = (@_); my (@v) = (@_);
my $max=undef;
if ($v1 > $v2) { foreach my $v (@v) {
return $v1; if (!defined $max or $v > $max) {
} else { $max = $v;
return $v2; }
} }
return $max;
} }
sub set_fans_default { sub set_fans_default {
@ -70,12 +77,6 @@ sub set_fans_servo {
my (@coretemps) = @$_coretemps; my (@coretemps) = @$_coretemps;
my (@hddtemps) = @$_hddtemps; my (@hddtemps) = @$_hddtemps;
if (!defined $current_mode or $current_mode ne "set") {
$current_mode="set";
print "--> disable dynamic fan control\n";
system("ipmitool raw 0x30 0x30 0x01 0x00");
}
# two thirds weighted CPU temps vs hdd temps, but if the HDD temps # two thirds weighted CPU temps vs hdd temps, but if the HDD temps
# creep above this value, use them exclusively (more important to # creep above this value, use them exclusively (more important to
# keep them cool than the CPUs) # keep them cool than the CPUs)
@ -83,8 +84,19 @@ sub set_fans_servo {
average(@cputemps), average(@coretemps), average(@hddtemps)), average(@cputemps), average(@coretemps), average(@hddtemps)),
average(@hddtemps)); average(@hddtemps));
if (!defined $weighted_temp) {
print "Error reading all temperatures! Fallback to idrac control\n";
set_fans_default();
return;
}
print "weighted_temp = $weighted_temp ; ambient_temp $ambient_temp\n"; print "weighted_temp = $weighted_temp ; ambient_temp $ambient_temp\n";
if (!defined $current_mode or $current_mode ne "set") {
$current_mode="set";
print "--> disable dynamic fan control\n";
system("ipmitool raw 0x30 0x30 0x01 0x00");
}
# FIXME: probably want to take into account ambient temperature - if # FIXME: probably want to take into account ambient temperature - if
# the difference between weighted_temp and ambient_temp is small # the difference between weighted_temp and ambient_temp is small
# because ambient_temp is large, then less need to run the fans # because ambient_temp is large, then less need to run the fans
@ -118,10 +130,18 @@ sub set_fans_servo {
# print "demand = $demand\n"; # print "demand = $demand\n";
print "--> ipmitool raw 0x30 0x30 0x02 0xff $demand\n"; print "--> ipmitool raw 0x30 0x30 0x02 0xff $demand\n";
system("ipmitool raw 0x30 0x30 0x02 0xff $demand"); system("ipmitool raw 0x30 0x30 0x02 0xff $demand");
} else {
print "demand = $demand\n";
} }
} }
$SIG{TERM} = $SIG{INT} = sub { my $signame = shift ; $SIG{$signame} = 'DEFAULT' ; set_fans_default ; kill $signame, $$ }; $SIG{TERM} = $SIG{INT} = sub { my $signame = shift ; $SIG{$signame} = 'DEFAULT' ; print "Resetting fans back to default\n"; set_fans_default ; kill $signame, $$ };
END {
my $exit = $?;
print "Resetting fans back to default\n";
set_fans_default;
$? = $exit;
}
my $last_reset_hddtemps=time; my $last_reset_hddtemps=time;
my $last_reset_ambient_ipmitemps=time; my $last_reset_ambient_ipmitemps=time;
@ -159,6 +179,7 @@ while () {
my $ambient_temp = average(@ambient_ipmitemps); my $ambient_temp = average(@ambient_ipmitemps);
# FIXME: hysteresis # FIXME: hysteresis
if ($ambient_temp > $default_threshold) { if ($ambient_temp > $default_threshold) {
print "fallback because of high ambient temperature $ambient_temp > $default_threshold\n";
set_fans_default(); set_fans_default();
} else { } else {
set_fans_servo($ambient_temp, \@cputemps, \@coretemps, \@hddtemps); set_fans_servo($ambient_temp, \@cputemps, \@coretemps, \@hddtemps);