danvics/R710-Fan-Control
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: be quiet when the $quiet flag is set

Browse source 
My syslogs are basically flooded with that "--> disable dynamic fan control" message.
Despite passing the -q flag in the systemd unit file, the logs from this program (and more specifically, that single message) make up at least 60% of my log entries.

This fixes that issue by only printing the message when quiet is false.
This commit is contained in:
Anthony Rubick 2025-07-28 00:33:26 -07:00
parent 74b8adc61c
commit a536821c02
No known key found for this signature in database
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
poweredge-fand.pl
View file

@ -129,7 +129,7 @@ sub set_fans_servo {
print "weighted_temp = $weighted_temp ; ambient_temp $ambient_temp\n" if $print_stats;
if ((!defined $current_mode) or ($current_mode ne "set")) {
print "--> disable dynamic fan control\n";
print "--> disable dynamic fan control\n" if !$quiet;
system("ipmitool raw 0x30 0x30 0x01 0x00") == 0 or return 0;
# if this fails, want to return telling caller not to think weve
# made a change