Pulse/internal
rcourtman e0d7cc7f58 fix: Address final Codex review findings
Fixed three remaining issues from Codex's final review:

**1. nullglob State Management (line 3124)**
- Replaced shopt -s/u nullglob with compgen -G check
- Prevents changing global shell behavior that could affect later globs
- More explicit and safer pattern matching

**2. authorized_keys Permission Preservation (lines 3116-3117)**
- Now uses chmod/chown --reference to preserve original ownership/perms
- Falls back gracefully if --reference not available
- Proper cleanup on mv failure to prevent temp file leaks
- Aborts atomically if operations fail, leaving original untouched

**3. Multi-Address Container Detection (lines 3750-3761)**
- Iterates over ALL IPs from hostname -I, not just first one
- Handles dual-stack (IPv4 + IPv6) and multi-IP containers
- Uses break 2 to exit both loops when match found
- Prevents false negatives when Pulse IP is not the first address

All operations now handle edge cases properly: non-root accounts,
dual-stack networking, empty directories, and partial failures.

Addresses #123
2025-10-13 14:32:38 +00:00
..
adapters Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
alerts Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
api fix: Address final Codex review findings 2025-10-13 14:32:38 +00:00
auth Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
config Fix node config API to preserve fields on partial updates 2025-10-12 17:50:55 +00:00
crypto Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
discovery Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
dockeragent Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
errors Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
interfaces Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
mock fix: Add hasCPU/hasNVMe flags to prevent false 'no CPU sensor' errors 2025-10-13 10:17:17 +00:00
models fix: Add hasCPU/hasNVMe flags to prevent false 'no CPU sensor' errors 2025-10-13 10:17:17 +00:00
monitoring fix: Add hasCPU/hasNVMe flags to prevent false 'no CPU sensor' errors 2025-10-13 10:17:17 +00:00
notifications Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
tempproxy refactor: Rename pulse-temp-proxy to pulse-sensor-proxy 2025-10-13 13:17:05 +00:00
types Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
updates chore: bump version to v4.23.0 2025-10-12 16:35:48 +00:00
utils Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
websocket Fix settings security tab navigation 2025-10-11 23:29:47 +00:00