Pulse/internal
rcourtman 096801e96a fix: Improve setup script robustness and safety (Codex review)
Applied Codex's security and reliability recommendations:

**SSH Key Safety:**
- Added "pulse-managed-key" comment marker to all SSH keys
- Removal now targets only marked keys (prevents deleting operator keys)
- Uses atomic file replacement via mktemp for authorized_keys edits

**Idempotency Improvements:**
- LXC config glob now uses nullglob to handle empty directories
- pveum token removal handles missing users gracefully (|| printf '')
- All systemctl operations wrapped with || true for non-systemd hosts
- sed operations in loops protected with || true

**Container Detection:**
- Validates container is running before IP check (pct status)
- Confirms container exists with pct config before proceeding
- Uses printf '' instead of || true for command substitution
- Handles IPv6 and multi-IP scenarios more reliably

**Network Operations:**
- curl now uses --fail --show-error --silent --location
- Error messages visible to users instead of silenced
- Better diagnostics when download fails

**Migration Safety:**
- Verifies pulse-sensor-proxy service is active before key removal
- Fallback check for binary existence if systemd unavailable
- Preserves legacy SSH keys if proxy not confirmed healthy
- Clear messaging about deferred cleanup

All cleanup operations are now fully idempotent and safe for
repeated execution, even on partially-configured hosts.

Addresses #123
2025-10-13 14:19:17 +00:00
..
adapters Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
alerts Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
api fix: Improve setup script robustness and safety (Codex review) 2025-10-13 14:19:17 +00:00
auth Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
config Fix node config API to preserve fields on partial updates 2025-10-12 17:50:55 +00:00
crypto Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
discovery Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
dockeragent Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
errors Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
interfaces Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
mock fix: Add hasCPU/hasNVMe flags to prevent false 'no CPU sensor' errors 2025-10-13 10:17:17 +00:00
models fix: Add hasCPU/hasNVMe flags to prevent false 'no CPU sensor' errors 2025-10-13 10:17:17 +00:00
monitoring fix: Add hasCPU/hasNVMe flags to prevent false 'no CPU sensor' errors 2025-10-13 10:17:17 +00:00
notifications Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
tempproxy refactor: Rename pulse-temp-proxy to pulse-sensor-proxy 2025-10-13 13:17:05 +00:00
types Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
updates chore: bump version to v4.23.0 2025-10-12 16:35:48 +00:00
utils Fix settings security tab navigation 2025-10-11 23:29:47 +00:00
websocket Fix settings security tab navigation 2025-10-11 23:29:47 +00:00