Updated CLEANUP_TODO.md with comprehensive documentation of all 8 critical
issues identified by Codex review (conv-1763166192078-1076) and their
resolutions.
Key updates:
- Added detailed problem/fix/impact for each issue
- Updated status to 'Codex review complete, ready for deployment testing'
- Documented all commits in implementation history
- Added Codex review summary section
- Marked phases 1-6 as complete, phase 7 (testing) as pending
This provides complete audit trail of cleanup implementation work.
All phases of full cleanup implementation are now complete:
- Phase 1: Binary relocation to /opt ✅
- Phase 2: Process isolation via systemd-run ✅
- Phase 3: flock serialization and immediate file deletion ✅
- Phase 4: Improved API token parsing ✅
- Phase 5: Testing (pending)
Updated status from 'requires architectural changes' to 'complete, ready for testing'.
The full cleanup implementation (ed65fda74) has architectural issues that need addressing:
1. Read-only /usr filesystems prevent binary removal
2. Process isolation issues cause cleanup service to be killed
3. Cleanup loops from improper request file handling
This TODO documents the required changes following Codex recommendations:
- Relocate binaries to /opt/pulse/sensor-proxy/
- Use transient systemd units for uninstall orchestration
- Add flock serialization and proper cleanup-request handling
Current state: SSH keys are removed (critical), full cleanup needs refactoring.
