Pulse

danvics/Pulse

Fork 0

Commit graph

Author	SHA1	Message	Date
rcourtman	b604a63322	Fix critical release workflow issues identified in review Addresses 3 critical issues from 4-dev team review: 1. CRITICAL: Fix non-deterministic checksum generation (Dev 2 & 3) - Add explicit sorting to checksums.txt generation - Prevents #671 checksum mismatches between builds - Location: scripts/build-release.sh:348 2. CRITICAL: Fix upload/validation race condition (Dev 1) - Change validation trigger from 'release: created' to 'workflow_run' - Prevents validation from running while assets still uploading - Prevents valid releases from being incorrectly deleted - Location: .github/workflows/validate-release-assets.yml:4-8 3. CRITICAL: Fix GitHub token exposure in logs (Dev 1) - Replace curl commands with gh CLI - Prevents token leakage in workflow logs - Location: .github/workflows/validate-release-assets.yml:44, 63 All three issues were blocking issues that could cause release failures. Remaining high/medium priority issues to be addressed in follow-up PRs.	2025-11-11 11:32:44 +00:00
Claude	4620c1d2b3	Add post-upload validation gate for release assets Create GitHub Actions workflow that validates release assets AFTER they're uploaded to catch issues even if someone manually uploads or modifies assets. Features: - Triggers on release created/edited (draft only) - Downloads all assets from GitHub release - Re-runs scripts/validate-release.sh on downloaded assets - On validation failure: * Deletes all assets from the release * Sets commit status to failed * Updates release description with error details - On validation success: * Sets commit status to success * Updates release description with validation summary This acts as a safety gate to prevent publishing releases with: - Missing required files - Checksum mismatches - Incorrect version strings in binaries - Corrupted or incomplete uploads	2025-11-11 09:23:06 +00:00

Author

SHA1

Message

Date

rcourtman

b604a63322

Fix critical release workflow issues identified in review

Addresses 3 critical issues from 4-dev team review:

1. CRITICAL: Fix non-deterministic checksum generation (Dev 2 & 3)
   - Add explicit sorting to checksums.txt generation
   - Prevents #671 checksum mismatches between builds
   - Location: scripts/build-release.sh:348

2. CRITICAL: Fix upload/validation race condition (Dev 1)
   - Change validation trigger from 'release: created' to 'workflow_run'
   - Prevents validation from running while assets still uploading
   - Prevents valid releases from being incorrectly deleted
   - Location: .github/workflows/validate-release-assets.yml:4-8

3. CRITICAL: Fix GitHub token exposure in logs (Dev 1)
   - Replace curl commands with gh CLI
   - Prevents token leakage in workflow logs
   - Location: .github/workflows/validate-release-assets.yml:44, 63

All three issues were blocking issues that could cause release failures.
Remaining high/medium priority issues to be addressed in follow-up PRs.

2025-11-11 11:32:44 +00:00

Claude

4620c1d2b3

Add post-upload validation gate for release assets

Create GitHub Actions workflow that validates release assets AFTER they're uploaded
to catch issues even if someone manually uploads or modifies assets.

Features:
- Triggers on release created/edited (draft only)
- Downloads all assets from GitHub release
- Re-runs scripts/validate-release.sh on downloaded assets
- On validation failure:
  * Deletes all assets from the release
  * Sets commit status to failed
  * Updates release description with error details
- On validation success:
  * Sets commit status to success
  * Updates release description with validation summary

This acts as a safety gate to prevent publishing releases with:
- Missing required files
- Checksum mismatches
- Incorrect version strings in binaries
- Corrupted or incomplete uploads

2025-11-11 09:23:06 +00:00

2 commits