4 commits

Author	SHA1	Message	Date
rcourtman	8fca8c6eb4	Refactor alert system: fix race conditions, memory leaks, and improve code quality ... - Rename checkFlapping to checkFlappingLocked to clarify lock contract - Replace goto statements with structured control flow - Wire up unused recordAlertFired/recordAlertResolved metric hooks - Add trackingMapCleanup goroutine to prevent memory leaks from stale entries - Tighten alert ID validation to alphanumeric + safe punctuation - Fix history save error handling to properly manage backup lifecycle - Add auto-migration for deprecated GroupingWindow field - Refactor 300+ line UpdateConfig into focused helper functions - Unify duplicate evaluateVMCondition/evaluateContainerCondition - Add constants for magic numbers (thresholds, timing, flapping) - Update tests to match new backup behavior	2025-12-02 23:31:36 +00:00
rcourtman	72af7bed5e	style: Apply gofmt to 37 files ... Standardize code formatting across test files and monitor.go. No functional changes.	2025-12-02 17:21:48 +00:00
rcourtman	5deca850d4	test: Add saveHistoryWithRetry tests for alerts package ... Add comprehensive tests for the saveHistoryWithRetry function covering: - Backup file creation from existing history - Empty history serialization - Single retry success - Read-only directory failure with retries - Concurrent saves with serialization via saveMu - Snapshot isolation during save Coverage: saveHistoryWithRetry 58.6% → 86.2% Coverage: alerts package 87.4% → 87.8%	2025-12-02 12:49:27 +00:00
rcourtman	f184174f2b	test: Add HistoryManager tests for alerts package ... New history_test.go with 24 tests covering GetStats, getFileSize, AddAlert, GetHistory, GetAllHistory, RemoveAlert, ClearAllHistory, cleanOldEntries, saveHistory, loadHistory. Alerts package 83.6%→84.0%.	2025-12-02 12:06:53 +00:00