From e7cf40c2c633e97669c3ce476eaae52edfb21741 Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Mon, 1 Dec 2025 15:56:11 +0000
Subject: [PATCH] test: Add empty ID test for HandleDockerHostRemoved function
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- empty host ID is noop (preserves existing alerts/tracking)
- HandleDockerHostRemoved 75%→100%
---
 internal/alerts/alerts_test.go | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/internal/alerts/alerts_test.go b/internal/alerts/alerts_test.go
index 2b1fd93..2d4c612 100644
--- a/internal/alerts/alerts_test.go
+++ b/internal/alerts/alerts_test.go
@@ -3540,3 +3540,30 @@ func TestCleanupHostDiskAlerts(t *testing.T) {
 		}
 	})
 }
+
+func TestHandleDockerHostRemovedEmptyID(t *testing.T) {
+	t.Parallel()
+	m := NewManager()
+
+	// Create some alerts that should not be touched
+	m.mu.Lock()
+	m.activeAlerts["docker-host-offline-host1"] = &Alert{ID: "docker-host-offline-host1"}
+	m.dockerOfflineCount["host1"] = 3
+	m.mu.Unlock()
+
+	// Call with empty ID - should be noop
+	host := models.DockerHost{ID: ""}
+	m.HandleDockerHostRemoved(host)
+
+	m.mu.RLock()
+	_, alertExists := m.activeAlerts["docker-host-offline-host1"]
+	_, countExists := m.dockerOfflineCount["host1"]
+	m.mu.RUnlock()
+
+	if !alertExists {
+		t.Error("expected alert to remain when host ID is empty")
+	}
+	if !countExists {
+		t.Error("expected offline count to remain when host ID is empty")
+	}
+}