From e07bd834b6757ae49319475ffc3b365225959eda Mon Sep 17 00:00:00 2001 From: rcourtman Date: Tue, 2 Dec 2025 00:16:39 +0000 Subject: [PATCH] Filter virtual/system filesystems from host disk display Host disk bars were showing virtual filesystems like tmpfs, /dev, /run, /sys, and Docker overlay mounts. These clutter the UI and don't represent meaningful disk usage. Changed from `shouldIgnoreReadOnlyFilesystem` (read-only only) to the full `fsfilters.ShouldSkipFilesystem` which also excludes: - Virtual FS types: tmpfs, devtmpfs, sysfs, proc, cgroup, etc. - Special mountpoints: /dev, /proc, /sys, /run, /var/lib/docker, /snap - Network filesystems: fuse, nfs, cifs, etc. Related to #790 --- internal/monitoring/monitor.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/monitoring/monitor.go b/internal/monitoring/monitor.go index 9cf1383..e02579b 100644 --- a/internal/monitoring/monitor.go +++ b/internal/monitoring/monitor.go @@ -1856,10 +1856,10 @@ func (m *Monitor) ApplyHostReport(report agentshost.Report, tokenRecord *config. disks := make([]models.Disk, 0, len(report.Disks)) for _, disk := range report.Disks { - // Filter read-only filesystems for backward compatibility with older host agents - // that don't have the filter built in. Prevents false alerts for snap mounts, - // immutable OS images, etc. (issues #505, #690). - if shouldIgnoreReadOnlyFilesystem(disk.Type, uint64(disk.TotalBytes), uint64(disk.UsedBytes)) { + // Filter virtual/system filesystems and read-only filesystems to avoid cluttering + // the UI with tmpfs, devtmpfs, /dev, /run, /sys, docker overlay mounts, snap mounts, + // immutable OS images, etc. (issues #505, #690, #790). + if shouldSkip, _ := fsfilters.ShouldSkipFilesystem(disk.Type, disk.Mountpoint, uint64(disk.TotalBytes), uint64(disk.UsedBytes)); shouldSkip { continue }