From c7d832c8d9f6b59ca8d631aa4fe198c3c23c960c Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Mon, 1 Dec 2025 15:04:37 +0000
Subject: [PATCH] test: Add comprehensive tests for BuildGuestKey function

- Test different instance and node (full format)
- Test same instance and node (short format)
- Test empty instance defaults to node
- Test whitespace trimming
- Improves BuildGuestKey coverage from 71.4% to 100%
---
 internal/alerts/alerts_test.go | 58 ++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/internal/alerts/alerts_test.go b/internal/alerts/alerts_test.go
index b3772e9..20a0e2f 100644
--- a/internal/alerts/alerts_test.go
+++ b/internal/alerts/alerts_test.go
@@ -1896,3 +1896,61 @@ func TestReevaluateClearsDockerContainerAlertWhenIgnoredPrefixAdded(t *testing.T
 		t.Fatalf("expected docker container alert to be cleared when ignored prefix is configured")
 	}
 }
+
+func TestBuildGuestKey(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		name     string
+		instance string
+		node     string
+		vmid     int
+		want     string
+	}{
+		{
+			name:     "different instance and node",
+			instance: "cluster-1",
+			node:     "pve-node",
+			vmid:     100,
+			want:     "cluster-1-pve-node-100",
+		},
+		{
+			name:     "same instance and node",
+			instance: "pve-node",
+			node:     "pve-node",
+			vmid:     200,
+			want:     "pve-node-200",
+		},
+		{
+			name:     "empty instance uses node",
+			instance: "",
+			node:     "pve-node",
+			vmid:     300,
+			want:     "pve-node-300",
+		},
+		{
+			name:     "whitespace instance uses node",
+			instance: "   ",
+			node:     "pve-node",
+			vmid:     400,
+			want:     "pve-node-400",
+		},
+		{
+			name:     "instance with whitespace trimmed",
+			instance: "  cluster-1  ",
+			node:     "pve-node",
+			vmid:     500,
+			want:     "cluster-1-pve-node-500",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+			got := BuildGuestKey(tt.instance, tt.node, tt.vmid)
+			if got != tt.want {
+				t.Errorf("BuildGuestKey(%q, %q, %d) = %q, want %q", tt.instance, tt.node, tt.vmid, got, tt.want)
+			}
+		})
+	}
+}