danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: Add DNS resolution failure test for ValidateWebhookURL

Browse source 
Tests the error path when webhook hostname cannot be resolved
(78.1% to 81.2% coverage).
This commit is contained in:
rcourtman 2025-12-02 01:09:03 +00:00
parent 3dba961abf
commit c080a6beb6
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
internal/notifications/webhook_allowlist_test.go
View file

@ -287,3 +287,16 @@ func TestValidateWebhookURLWithAllowlist(t *testing.T) {
t.Error("Expected error for link-local even with allowlist") t.Error("Expected error for link-local even with allowlist")
} }
} }
func TestValidateWebhookURL_DNSResolutionFailure(t *testing.T) {
nm := NewNotificationManager("")
// Use a hostname that will definitely not resolve
err := nm.ValidateWebhookURL("http://this-hostname-definitely-does-not-exist-12345.invalid/webhook")
if err == nil {
t.Error("Expected error for unresolvable hostname")
}
if !strings.Contains(err.Error(), "failed to resolve webhook hostname") {
t.Errorf("Expected DNS resolution error, got: %v", err)
}
}