danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: Add comprehensive tests for EmailTemplate function

Browse source 
Cover both branches: single alert template (isSingle=true with 1 alert)
and grouped alert template (isSingle=false or multiple alerts). Tests
verify subject format, HTML structure, and text body generation.
Coverage improved from 66.7% to 100%.
This commit is contained in:
rcourtman 2025-12-01 15:29:31 +00:00
parent 844b9e5637
commit a9fe80e1cd
1 changed files with 129 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

129
internal/notifications/email_template_test.go
View file

@ -1,8 +1,11 @@
package notifications package notifications
import ( import (
"strings"
"testing" "testing"
"time" "time"
"github.com/rcourtman/pulse-go-rewrite/internal/alerts"
) )
func TestTitleCase(t *testing.T) { func TestTitleCase(t *testing.T) {
@ -515,3 +518,129 @@ func TestFormatMetricThreshold(t *testing.T) {
}) })
} }
} }
func TestEmailTemplate(t *testing.T) {
t.Parallel()
tests := []struct {
name string
alerts []*alerts.Alert
isSingle bool
expectSingleSubject bool // subject contains single alert info vs "Multiple Alerts"
subjectContains string
}{
{
name: "single alert with isSingle=true uses single template",
alerts: []*alerts.Alert{
{
ID: "alert-1",
Level: "critical",
Type: "cpu",
ResourceName: "test-vm",
Value: 95.5,
Threshold: 90.0,
StartTime: time.Now(),
},
},
isSingle: true,
expectSingleSubject: true,
subjectContains: "test-vm",
},
{
name: "single alert with isSingle=false uses grouped template",
alerts: []*alerts.Alert{
{
ID: "alert-1",
Level: "warning",
Type: "memory",
ResourceName: "test-vm",
Value: 85.0,
Threshold: 80.0,
StartTime: time.Now(),
},
},
isSingle: false,
expectSingleSubject: false,
subjectContains: "1 Warning alert", // Grouped template uses "N Level alert(s)"
},
{
name: "multiple alerts uses grouped template regardless of isSingle",
alerts: []*alerts.Alert{
{
ID: "alert-1",
Level: "critical",
Type: "cpu",
ResourceName: "vm-1",
Value: 95.5,
Threshold: 90.0,
StartTime: time.Now(),
},
{
ID: "alert-2",
Level: "warning",
Type: "memory",
ResourceName: "vm-2",
Value: 85.0,
Threshold: 80.0,
StartTime: time.Now(),
},
},
isSingle: true, // Even with isSingle=true, multiple alerts use grouped
expectSingleSubject: false,
subjectContains: "Critical", // Subject shows level counts
},
{
name: "warning level alert",
alerts: []*alerts.Alert{
{
ID: "alert-1",
Level: "warning",
Type: "disk",
ResourceName: "storage-1",
Value: 88.0,
Threshold: 85.0,
StartTime: time.Now(),
},
},
isSingle: true,
expectSingleSubject: true,
subjectContains: "Warning",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
subject, htmlBody, textBody := EmailTemplate(tt.alerts, tt.isSingle)
// Check subject contains expected content
if !strings.Contains(subject, tt.subjectContains) {
t.Errorf("subject = %q, want to contain %q", subject, tt.subjectContains)
}
// Verify HTML body is not empty and contains basic structure
if htmlBody == "" {
t.Error("htmlBody is empty")
}
if !strings.Contains(htmlBody, "<!DOCTYPE html>") {
t.Error("htmlBody missing DOCTYPE")
}
if !strings.Contains(htmlBody, "</html>") {
t.Error("htmlBody missing closing html tag")
}
// Verify text body is not empty
if textBody == "" {
t.Error("textBody is empty")
}
// Check for single vs grouped template indicators
if tt.expectSingleSubject {
if strings.Contains(subject, "Multiple") || strings.Contains(subject, "Alerts]") {
t.Errorf("expected single alert subject, got grouped: %q", subject)
}
}
})
}
}