danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: show success message instead of warning when using pulse-sensor-proxy

Browse source 
When the setup script detects TEMPERATURE_PROXY_KEY (proxy is available),
it now shows a clear success message instead of attempting SSH verification.

The verification check doesn't work with proxy-based setups since the
container doesn't have SSH keys - all temperature collection happens via
the Unix socket to pulse-sensor-proxy, which handles SSH.

Now shows:
✓ Temperature monitoring configured via pulse-sensor-proxy
  Temperature data will appear in the dashboard within 10 seconds

Instead of the misleading:
⚠️  Unable to verify SSH connectivity.
   Temperature data will appear once SSH connectivity is configured.
This commit is contained in:
rcourtman 2025-10-19 14:06:18 +00:00
parent 557eedb247
commit a841a1a6fe
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
internal/api/config_handlers.go
View file

@ -4168,16 +4168,15 @@ EOF
# Verify that Pulse can actually SSH to the configured nodes
echo ""
# Only verify connectivity if not containerized or if proxy is installed
# Containerized Pulse without proxy cannot directly SSH to nodes
SHOULD_VERIFY_SSH=false
if [ "$PULSE_IS_CONTAINERIZED" != true ]; then
SHOULD_VERIFY_SSH=true
elif systemctl is-active --quiet pulse-sensor-proxy 2>/dev/null; then
SHOULD_VERIFY_SSH=true
fi
if [ "$SHOULD_VERIFY_SSH" = true ]; then
# Check if we're using the temperature proxy
# If proxy key was detected earlier, we're using proxy-based temperature monitoring
if [ -n "$TEMPERATURE_PROXY_KEY" ]; then
# Using proxy - verification not needed, proxy handles SSH
echo "✓ Temperature monitoring configured via pulse-sensor-proxy"
echo " Temperature data will appear in the dashboard within 10 seconds"
echo ""
elif [ "$PULSE_IS_CONTAINERIZED" != true ]; then
# Non-containerized Pulse - can verify SSH directly
echo "Verifying temperature monitoring connectivity from Pulse..."
echo ""