From a5fb98e7c6de193024e80fb6fc0426c2bf5860fa Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Sun, 23 Nov 2025 09:09:37 +0000
Subject: [PATCH] Fix: create git tag explicitly before release

gh release create with --target was still creating untagged releases.
The fix is to create and push the git tag explicitly first, then
create the release which will properly attach to the existing tag.
---
 .github/workflows/create-release.yml | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml
index 8353b2d..0c3ca6e 100644
--- a/.github/workflows/create-release.yml
+++ b/.github/workflows/create-release.yml
@@ -407,6 +407,15 @@ jobs:
           echo "Release notes content:"
           cat "$NOTES_FILE"
 
+      - name: Create git tag
+        run: |
+          TAG="${{ needs.extract_version.outputs.tag }}"
+
+          echo "Creating git tag ${TAG}..."
+          git tag "${TAG}" "${{ github.sha }}"
+          git push origin "${TAG}"
+          echo "✓ Tag ${TAG} created and pushed"
+
       - name: Create draft release
         id: create_release
         env:
@@ -417,13 +426,11 @@ jobs:
 
           echo "Creating draft release for ${TAG}..."
 
-          # Create the tag and release together
-          # gh release create will create both the tag and the release
+          # Tag now exists, so gh release create will attach to it
           gh release create "${TAG}" \
             --draft \
             --title "Pulse ${TAG}" \
-            --notes-file "$NOTES_FILE" \
-            --target "${{ github.sha }}"
+            --notes-file "$NOTES_FILE"
 
           rm -f "$NOTES_FILE"