danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix test failures from API signature changes

Browse source 
Fixed two test failures identified by go vet:

1. SSH knownhosts manager tests
   - Updated keyscanFunc signatures from (ctx, host, timeout) to (ctx, host, port, timeout)
   - Affected 4 test functions in manager_test.go
   - Matches recent API change adding port parameter for flexibility

2. Monitor temperature toggle test
   - Removed obsolete test file monitor_temperature_toggle_test.go
   - Test was checking internal implementation details that have changed
   - Enable/DisableTemperatureMonitoring() now only log (interface compatibility)
   - Temperature collection is managed differently in current architecture

Impact:
- All tests now compile successfully
- Removes obsolete test that no longer reflects current behavior
- Updates remaining tests to match current API signatures
This commit is contained in:
rcourtman 2025-11-07 10:43:06 +00:00
parent d30d76bb92
commit 94b07a892e
2 changed files with 4 additions and 47 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
internal/monitoring/monitor_temperature_toggle_test.go
View file

@ -1,43 +0,0 @@
package monitoring
import (
"path/filepath"
"testing"
"github.com/rcourtman/pulse-go-rewrite/internal/config"
)
func TestMonitorTemperatureCollectorToggle(t *testing.T) {
t.Parallel()
cfg := &config.Config{TemperatureMonitoringEnabled: false}
service := newTemperatureService(false, "root", filepath.Join(t.TempDir(), "id_ed25519_sensors"), 22)
m := &Monitor{
config: cfg,
tempService: service,
}
if provider := m.temperatureService(); provider == nil {
t.Fatalf("expected temperature service to be present")
} else if provider.Enabled() {
t.Fatalf("expected service to start disabled")
}
m.EnableTemperatureMonitoring()
if !cfg.TemperatureMonitoringEnabled {
t.Fatalf("expected config flag to be true after enabling")
}
if provider := m.temperatureService(); provider == nil || !provider.Enabled() {
t.Fatalf("expected service to be enabled after EnableTemperatureMonitoring")
}
m.DisableTemperatureMonitoring()
if cfg.TemperatureMonitoringEnabled {
t.Fatalf("expected config flag to be false after disabling")
}
if provider := m.temperatureService(); provider == nil || provider.Enabled() {
t.Fatalf("expected service to be disabled after DisableTemperatureMonitoring")
}
}

8
internal/ssh/knownhosts/manager_test.go
View file

@ -14,7 +14,7 @@ func TestEnsureCreatesFileAndCaches(t *testing.T) {
path := filepath.Join(dir, "known_hosts")
var calls int
keyscan := func(ctx context.Context, host string, timeout time.Duration) ([]byte, error) {
keyscan := func(ctx context.Context, host string, port int, timeout time.Duration) ([]byte, error) {
calls++
return []byte(host + " ssh-ed25519 AAAA"), nil
}
@ -44,7 +44,7 @@ func TestEnsureUsesSanitizedOutput(t *testing.T) {
dir := t.TempDir()
path := filepath.Join(dir, "known_hosts")
keyscan := func(ctx context.Context, host string, timeout time.Duration) ([]byte, error) {
keyscan := func(ctx context.Context, host string, port int, timeout time.Duration) ([]byte, error) {
return []byte(`# comment
example.com ssh-ed25519 AAAA
example.com,192.0.2.10 ssh-rsa BBBB
@ -74,7 +74,7 @@ func TestEnsureReturnsErrorWhenNoEntries(t *testing.T) {
dir := t.TempDir()
path := filepath.Join(dir, "known_hosts")
mgr, err := NewManager(path, WithKeyscanFunc(func(ctx context.Context, host string, timeout time.Duration) ([]byte, error) {
mgr, err := NewManager(path, WithKeyscanFunc(func(ctx context.Context, host string, port int, timeout time.Duration) ([]byte, error) {
return []byte("|1|hash|salt ssh-ed25519 AAAA\n"), nil
}))
if err != nil {
@ -91,7 +91,7 @@ func TestEnsureRespectsContextCancellation(t *testing.T) {
dir := t.TempDir()
path := filepath.Join(dir, "known_hosts")
keyscan := func(ctx context.Context, host string, timeout time.Duration) ([]byte, error) {
keyscan := func(ctx context.Context, host string, port int, timeout time.Duration) ([]byte, error) {
<-ctx.Done()
return nil, ctx.Err()
}