danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Relax container SSH check for temperature monitoring (ref #727)

Browse source
This commit is contained in:
courtmanr@gmail.com 2025-11-25 08:00:08 +00:00
parent 15e96458e2
commit 8b7ff2ad48
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
internal/monitoring/temperature.go
View file

@ -177,10 +177,11 @@ func (tc *TemperatureCollector) CollectTemperatureWithProxy(ctx context.Context,
} }
if isContainer && !devModeAllowSSH { if isContainer && !devModeAllowSSH {
// Warn but allow if key is present (legacy behavior restoration)
// We don't return here, allowing the code to fall through to the SSH key check
log.Warn(). log.Warn().
Str("node", nodeName). Str("node", nodeName).
Msg("Temperature collection disabled: containerized Pulse requires pulse-sensor-proxy. Mount /run/pulse-sensor-proxy or set PULSE_DEV_ALLOW_CONTAINER_SSH=true for development only") Msg("Temperature collection using direct SSH from container. This is insecure. Recommend using pulse-sensor-proxy.")
return &models.Temperature{Available: false}, nil
} }
if strings.TrimSpace(tc.sshKeyPath) == "" { if strings.TrimSpace(tc.sshKeyPath) == "" {