danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(api): allow printable alert IDs for acknowledge (Related to #852)

Browse source
This commit is contained in:
rcourtman 2025-12-17 20:09:51 +00:00
parent 65a4534be9
commit 834549875d
1 changed files with 26 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
internal/api/router_integration_test.go
View file

@ -169,6 +169,32 @@ func TestVersionEndpointUsesRepoVersion(t *testing.T) {
t.Fatalf("expected version to match release %q or runtime %q, got %s", releaseVersion, runtimeVersion, actual)
}
func TestAlertAcknowledge_AllowsPrintableAlertIDs(t *testing.T) {
srv := newIntegrationServer(t)
// This ID includes parentheses which were rejected in v5 RC builds due to overly strict
// validation. The request should make it to the alert manager, which returns 404 because
// the alert does not exist in this test environment.
alertID := "docker(host)-container-unhealthy"
escaped := url.PathEscape(alertID)
req, err := http.NewRequest(http.MethodPost, srv.server.URL+"/api/alerts/"+escaped+"/acknowledge", nil)
if err != nil {
t.Fatalf("create request: %v", err)
}
res, err := http.DefaultClient.Do(req)
if err != nil {
t.Fatalf("ack request failed: %v", err)
}
defer res.Body.Close()
if res.StatusCode != http.StatusNotFound {
body, _ := io.ReadAll(res.Body)
t.Fatalf("unexpected status: got %d want %d, body=%s", res.StatusCode, http.StatusNotFound, string(body))
}
}
func TestStateEndpointReturnsMockData(t *testing.T) {
srv := newIntegrationServer(t)