security: Add request body size limits to API handlers
Add http.MaxBytesReader to 16 additional handlers to prevent memory exhaustion attacks via oversized request bodies: - docker_agents.go: HandleReport (512KB), HandleCommandAck (8KB), HandleSetCustomDisplayName (8KB) - alerts.go: UpdateAlertConfig (64KB), BulkAcknowledgeAlerts (32KB), BulkClearAlerts (32KB) - config_handlers.go: HandleAddNode, HandleTestConnection, HandleUpdateNode, HandleTestNodeConfig (32KB each), HandleVerifyTemperatureSSH, HandleExportConfig, HandleDiscoverServers, HandleSetupScriptURL (8KB each), HandleImportConfig (1MB), HandleUpdateMockMode (16KB)
This commit is contained in:
parent
ccc26624e8
commit
7b55564b62
3 changed files with 46 additions and 0 deletions
|
|
@ -71,6 +71,9 @@ func (h *AlertHandlers) GetAlertConfig(w http.ResponseWriter, r *http.Request) {
|
||||||
|
|
||||||
// UpdateAlertConfig updates the alert configuration
|
// UpdateAlertConfig updates the alert configuration
|
||||||
func (h *AlertHandlers) UpdateAlertConfig(w http.ResponseWriter, r *http.Request) {
|
func (h *AlertHandlers) UpdateAlertConfig(w http.ResponseWriter, r *http.Request) {
|
||||||
|
// Limit request body to 64KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 64*1024)
|
||||||
|
|
||||||
var config alerts.AlertConfig
|
var config alerts.AlertConfig
|
||||||
if err := json.NewDecoder(r.Body).Decode(&config); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&config); err != nil {
|
||||||
http.Error(w, err.Error(), http.StatusBadRequest)
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
||||||
|
|
@ -561,6 +564,9 @@ func (h *AlertHandlers) ClearAlert(w http.ResponseWriter, r *http.Request) {
|
||||||
|
|
||||||
// BulkAcknowledgeAlerts acknowledges multiple alerts at once
|
// BulkAcknowledgeAlerts acknowledges multiple alerts at once
|
||||||
func (h *AlertHandlers) BulkAcknowledgeAlerts(w http.ResponseWriter, r *http.Request) {
|
func (h *AlertHandlers) BulkAcknowledgeAlerts(w http.ResponseWriter, r *http.Request) {
|
||||||
|
// Limit request body to 32KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 32*1024)
|
||||||
|
|
||||||
var request struct {
|
var request struct {
|
||||||
AlertIDs []string `json:"alertIds"`
|
AlertIDs []string `json:"alertIds"`
|
||||||
User string `json:"user,omitempty"`
|
User string `json:"user,omitempty"`
|
||||||
|
|
@ -623,6 +629,9 @@ func (h *AlertHandlers) BulkAcknowledgeAlerts(w http.ResponseWriter, r *http.Req
|
||||||
|
|
||||||
// BulkClearAlerts clears multiple alerts at once
|
// BulkClearAlerts clears multiple alerts at once
|
||||||
func (h *AlertHandlers) BulkClearAlerts(w http.ResponseWriter, r *http.Request) {
|
func (h *AlertHandlers) BulkClearAlerts(w http.ResponseWriter, r *http.Request) {
|
||||||
|
// Limit request body to 32KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 32*1024)
|
||||||
|
|
||||||
var request struct {
|
var request struct {
|
||||||
AlertIDs []string `json:"alertIds"`
|
AlertIDs []string `json:"alertIds"`
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -1155,6 +1155,9 @@ func (h *ConfigHandlers) HandleAddNode(w http.ResponseWriter, r *http.Request) {
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Limit request body to 32KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 32*1024)
|
||||||
|
|
||||||
var req NodeConfigRequest
|
var req NodeConfigRequest
|
||||||
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
||||||
log.Error().Err(err).Msg("Failed to decode add node request")
|
log.Error().Err(err).Msg("Failed to decode add node request")
|
||||||
|
|
@ -1528,6 +1531,9 @@ func (h *ConfigHandlers) HandleAddNode(w http.ResponseWriter, r *http.Request) {
|
||||||
|
|
||||||
// HandleTestConnection tests a node connection without saving
|
// HandleTestConnection tests a node connection without saving
|
||||||
func (h *ConfigHandlers) HandleTestConnection(w http.ResponseWriter, r *http.Request) {
|
func (h *ConfigHandlers) HandleTestConnection(w http.ResponseWriter, r *http.Request) {
|
||||||
|
// Limit request body to 32KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 32*1024)
|
||||||
|
|
||||||
var req NodeConfigRequest
|
var req NodeConfigRequest
|
||||||
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
||||||
log.Error().Err(err).Msg("Failed to decode test connection request")
|
log.Error().Err(err).Msg("Failed to decode test connection request")
|
||||||
|
|
@ -1836,6 +1842,9 @@ func (h *ConfigHandlers) HandleUpdateNode(w http.ResponseWriter, r *http.Request
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Limit request body to 32KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 32*1024)
|
||||||
|
|
||||||
var req NodeConfigRequest
|
var req NodeConfigRequest
|
||||||
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
||||||
http.Error(w, "Invalid request body", http.StatusBadRequest)
|
http.Error(w, "Invalid request body", http.StatusBadRequest)
|
||||||
|
|
@ -2333,6 +2342,9 @@ func (h *ConfigHandlers) triggerPVEHostCleanup(host string) {
|
||||||
|
|
||||||
// HandleTestNodeConfig tests a node connection from provided configuration
|
// HandleTestNodeConfig tests a node connection from provided configuration
|
||||||
func (h *ConfigHandlers) HandleTestNodeConfig(w http.ResponseWriter, r *http.Request) {
|
func (h *ConfigHandlers) HandleTestNodeConfig(w http.ResponseWriter, r *http.Request) {
|
||||||
|
// Limit request body to 32KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 32*1024)
|
||||||
|
|
||||||
var req NodeConfigRequest
|
var req NodeConfigRequest
|
||||||
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
||||||
http.Error(w, "Invalid request body", http.StatusBadRequest)
|
http.Error(w, "Invalid request body", http.StatusBadRequest)
|
||||||
|
|
@ -2750,6 +2762,9 @@ func (h *ConfigHandlers) HandleVerifyTemperatureSSH(w http.ResponseWriter, r *ht
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Limit request body to 8KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 8*1024)
|
||||||
|
|
||||||
var req struct {
|
var req struct {
|
||||||
Nodes string `json:"nodes"`
|
Nodes string `json:"nodes"`
|
||||||
}
|
}
|
||||||
|
|
@ -2838,6 +2853,9 @@ type ImportConfigRequest struct {
|
||||||
|
|
||||||
// HandleExportConfig exports all configuration with encryption
|
// HandleExportConfig exports all configuration with encryption
|
||||||
func (h *ConfigHandlers) HandleExportConfig(w http.ResponseWriter, r *http.Request) {
|
func (h *ConfigHandlers) HandleExportConfig(w http.ResponseWriter, r *http.Request) {
|
||||||
|
// Limit request body to 8KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 8*1024)
|
||||||
|
|
||||||
var req ExportConfigRequest
|
var req ExportConfigRequest
|
||||||
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
||||||
log.Error().Err(err).Msg("Failed to decode export request")
|
log.Error().Err(err).Msg("Failed to decode export request")
|
||||||
|
|
@ -2877,6 +2895,9 @@ func (h *ConfigHandlers) HandleExportConfig(w http.ResponseWriter, r *http.Reque
|
||||||
|
|
||||||
// HandleImportConfig imports configuration from encrypted export
|
// HandleImportConfig imports configuration from encrypted export
|
||||||
func (h *ConfigHandlers) HandleImportConfig(w http.ResponseWriter, r *http.Request) {
|
func (h *ConfigHandlers) HandleImportConfig(w http.ResponseWriter, r *http.Request) {
|
||||||
|
// Limit request body to 1MB to prevent memory exhaustion (config imports can be large)
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 1024*1024)
|
||||||
|
|
||||||
var req ImportConfigRequest
|
var req ImportConfigRequest
|
||||||
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
||||||
log.Error().Err(err).Msg("Failed to decode import request")
|
log.Error().Err(err).Msg("Failed to decode import request")
|
||||||
|
|
@ -3022,6 +3043,9 @@ func (h *ConfigHandlers) HandleDiscoverServers(w http.ResponseWriter, r *http.Re
|
||||||
return
|
return
|
||||||
|
|
||||||
case http.MethodPost:
|
case http.MethodPost:
|
||||||
|
// Limit request body to 8KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 8*1024)
|
||||||
|
|
||||||
var req struct {
|
var req struct {
|
||||||
Subnet string `json:"subnet"`
|
Subnet string `json:"subnet"`
|
||||||
UseCache bool `json:"use_cache"`
|
UseCache bool `json:"use_cache"`
|
||||||
|
|
@ -5199,6 +5223,9 @@ func (h *ConfigHandlers) HandleSetupScriptURL(w http.ResponseWriter, r *http.Req
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Limit request body to 8KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 8*1024)
|
||||||
|
|
||||||
// Parse request
|
// Parse request
|
||||||
var req struct {
|
var req struct {
|
||||||
Type string `json:"type"`
|
Type string `json:"type"`
|
||||||
|
|
@ -5325,6 +5352,9 @@ type mockModeRequest struct {
|
||||||
|
|
||||||
// HandleUpdateMockMode updates mock mode and optionally its configuration.
|
// HandleUpdateMockMode updates mock mode and optionally its configuration.
|
||||||
func (h *ConfigHandlers) HandleUpdateMockMode(w http.ResponseWriter, r *http.Request) {
|
func (h *ConfigHandlers) HandleUpdateMockMode(w http.ResponseWriter, r *http.Request) {
|
||||||
|
// Limit request body to 16KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 16*1024)
|
||||||
|
|
||||||
var req mockModeRequest
|
var req mockModeRequest
|
||||||
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
|
||||||
log.Error().Err(err).Msg("Failed to decode mock mode request")
|
log.Error().Err(err).Msg("Failed to decode mock mode request")
|
||||||
|
|
|
||||||
|
|
@ -67,6 +67,8 @@ func (h *DockerAgentHandlers) HandleReport(w http.ResponseWriter, r *http.Reques
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Limit request body to 512KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 512*1024)
|
||||||
defer r.Body.Close()
|
defer r.Body.Close()
|
||||||
|
|
||||||
var report agentsdocker.Report
|
var report agentsdocker.Report
|
||||||
|
|
@ -160,6 +162,9 @@ func (h *DockerAgentHandlers) HandleCommandAck(w http.ResponseWriter, r *http.Re
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Limit request body to 8KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 8*1024)
|
||||||
|
|
||||||
trimmed := strings.TrimPrefix(r.URL.Path, "/api/agents/docker/commands/")
|
trimmed := strings.TrimPrefix(r.URL.Path, "/api/agents/docker/commands/")
|
||||||
if !strings.HasSuffix(trimmed, "/ack") {
|
if !strings.HasSuffix(trimmed, "/ack") {
|
||||||
writeErrorResponse(w, http.StatusNotFound, "not_found", "Endpoint not found", nil)
|
writeErrorResponse(w, http.StatusNotFound, "not_found", "Endpoint not found", nil)
|
||||||
|
|
@ -420,6 +425,8 @@ func (h *DockerAgentHandlers) HandleSetCustomDisplayName(w http.ResponseWriter,
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Limit request body to 8KB to prevent memory exhaustion
|
||||||
|
r.Body = http.MaxBytesReader(w, r.Body, 8*1024)
|
||||||
defer r.Body.Close()
|
defer r.Body.Close()
|
||||||
|
|
||||||
var req struct {
|
var req struct {
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue