danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Force tcp4 network for IPv4 addresses in sensor-proxy HTTP mode

Browse source 
On dual-stack systems with net.ipv6.bindv6only=1 (like some Proxmox 8
configurations), Go's net.Listen("tcp", "0.0.0.0:8443") may still bind
to IPv6-only. This caused IPv4 localhost connections to hang while
IPv6 worked.

Fix by detecting IPv4 addresses and explicitly using "tcp4" network
type when creating the listener. Related to #805
This commit is contained in:
rcourtman 2025-12-04 20:09:37 +00:00
parent 715c0bb451
commit 77e59afe14
1 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
cmd/pulse-sensor-proxy/http_server.go
View file

@ -75,13 +75,34 @@ func (h *HTTPServer) Start() error {
TLSNextProto: make(map[string]func(*http.Server, *tls.Conn, http.Handler)),
}
// Determine network type based on address format
// Use tcp4 for IPv4 addresses to force IPv4-only binding on dual-stack systems
// Some systems (e.g., Proxmox 8 with net.ipv6.bindv6only=1) otherwise bind IPv6-only
network := "tcp"
addr := h.config.HTTPListenAddr
if strings.HasPrefix(addr, "0.0.0.0:") || (len(addr) > 0 && addr[0] >= '0' && addr[0] <= '9' && !strings.Contains(addr, "[")) {
// IPv4 address (starts with digit and no bracket)
network = "tcp4"
} else if strings.HasPrefix(addr, "[") {
// IPv6 address (starts with bracket)
network = "tcp6"
}
log.Info().
Str("addr", h.config.HTTPListenAddr).
Str("addr", addr).
Str("network", network).
Str("cert", h.config.HTTPTLSCertFile).
Msg("Starting HTTPS server")
// Create listener explicitly with the correct network type
// This ensures IPv4 addresses bind to IPv4-only sockets
ln, err := net.Listen(network, addr)
if err != nil {
return fmt.Errorf("failed to create listener: %w", err)
}
go func() {
if err := h.server.ListenAndServeTLS(h.config.HTTPTLSCertFile, h.config.HTTPTLSKeyFile); err != nil && err != http.ErrServerClosed {
if err := h.server.ServeTLS(ln, h.config.HTTPTLSCertFile, h.config.HTTPTLSKeyFile); err != nil && err != http.ErrServerClosed {
log.Error().Err(err).Msg("HTTPS server failed")
}
}()