danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: require explicit confirm before showing agent commands

Browse source
This commit is contained in:
rcourtman 2025-10-23 18:35:06 +00:00
parent 45e6ff48eb
commit 745e6b386b
2 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frontend-modern/src/components/Settings/DockerAgents.tsx
View file

@ -240,7 +240,6 @@ const modalCommandProgress = createMemo(() => {
setShowGenerateTokenModal(false); setShowGenerateTokenModal(false);
setNewTokenName(''); setNewTokenName('');
setLatestRecord(record); setLatestRecord(record);
setStepTwoComplete(true);
showTokenReveal({ showTokenReveal({
token, token,
record, record,
@ -504,8 +503,8 @@ WantedBy=multi-user.target`;
: 'border-blue-200 bg-blue-50 text-blue-800 dark:border-blue-800 dark:bg-blue-900/20 dark:text-blue-200' : 'border-blue-200 bg-blue-50 text-blue-800 dark:border-blue-800 dark:bg-blue-900/20 dark:text-blue-200'
}`}> }`}>
{stepTwoComplete() {stepTwoComplete()
? 'Token ready. You can continue to the install command.' ? 'Token inserted. Proceed to the install command below.'
: 'Stored token detected. Confirm to insert it into the install command.'} : 'Stored token detected. Press confirm to insert it into the command.'}
</div> </div>
<button <button
type="button" type="button"
@ -517,7 +516,7 @@ WantedBy=multi-user.target`;
: 'bg-gray-900 text-white hover:bg-black dark:bg-gray-100 dark:text-gray-900 dark:hover:bg-white' : 'bg-gray-900 text-white hover:bg-black dark:bg-gray-100 dark:text-gray-900 dark:hover:bg-white'
}`} }`}
> >
{stepTwoComplete() ? 'Token ready' : 'Use token in commands'} {stepTwoComplete() ? 'Token inserted' : 'Insert token into command'}
</button> </button>
</div> </div>
</Show> </Show>
@ -527,7 +526,7 @@ WantedBy=multi-user.target`;
<Show when={!requiresToken()}> <Show when={!requiresToken()}>
<div class="space-y-3"> <div class="space-y-3">
<div class="rounded-lg border border-amber-200 bg-amber-50 px-4 py-3 text-sm text-amber-800 dark:border-amber-700 dark:bg-amber-900/30 dark:text-amber-200"> <div class="rounded-lg border border-amber-200 bg-amber-50 px-4 py-3 text-sm text-amber-800 dark:border-amber-700 dark:bg-amber-900/30 dark:text-amber-200">
Tokens are optional on this Pulse instance. Confirm to continue to the install command. Tokens are optional on this Pulse instance. Confirm to generate commands without embedding a token.
</div> </div>
<button <button
type="button" type="button"
@ -539,7 +538,7 @@ WantedBy=multi-user.target`;
: 'bg-gray-900 text-white hover:bg-black dark:bg-gray-100 dark:text-gray-900 dark:hover:bg-white' : 'bg-gray-900 text-white hover:bg-black dark:bg-gray-100 dark:text-gray-900 dark:hover:bg-white'
}`} }`}
> >
{stepTwoComplete() ? 'Confirmed' : 'Confirm and continue'} {stepTwoComplete() ? 'No token confirmed' : 'Confirm without token'}
</button> </button>
</div> </div>
</Show> </Show>

11
frontend-modern/src/components/Settings/HostAgents.tsx
View file

@ -276,7 +276,6 @@ export const HostAgents: Component<HostAgentsProps> = (props) => {
setShowGenerateTokenModal(false); setShowGenerateTokenModal(false);
setNewTokenName(''); setNewTokenName('');
setLatestRecord(record); setLatestRecord(record);
setStepTwoComplete(true);
showTokenReveal({ showTokenReveal({
token, token,
record, record,
@ -464,8 +463,8 @@ export const HostAgents: Component<HostAgentsProps> = (props) => {
: 'border-blue-200 bg-blue-50 text-blue-800 dark:border-blue-800 dark:bg-blue-900/20 dark:text-blue-200' : 'border-blue-200 bg-blue-50 text-blue-800 dark:border-blue-800 dark:bg-blue-900/20 dark:text-blue-200'
}`}> }`}>
{stepTwoComplete() {stepTwoComplete()
? 'Token ready. You can continue to the commands.' ? 'Token inserted. Proceed to the install commands below.'
: 'Stored token detected. Confirm to insert it into the commands below.'} : 'Stored token detected. Press confirm to insert it into each command.'}
</div> </div>
<button <button
type="button" type="button"
@ -477,7 +476,7 @@ export const HostAgents: Component<HostAgentsProps> = (props) => {
: 'bg-gray-900 text-white hover:bg-black dark:bg-gray-100 dark:text-gray-900 dark:hover:bg-white' : 'bg-gray-900 text-white hover:bg-black dark:bg-gray-100 dark:text-gray-900 dark:hover:bg-white'
}`} }`}
> >
{stepTwoComplete() ? 'Token ready' : 'Use token in commands'} {stepTwoComplete() ? 'Token inserted' : 'Insert token into commands'}
</button> </button>
</div> </div>
</Show> </Show>
@ -487,7 +486,7 @@ export const HostAgents: Component<HostAgentsProps> = (props) => {
<Show when={!requiresToken()}> <Show when={!requiresToken()}>
<div class="space-y-3"> <div class="space-y-3">
<div class="rounded-lg border border-amber-200 bg-amber-50 px-4 py-3 text-sm text-amber-800 dark:border-amber-700 dark:bg-amber-900/30 dark:text-amber-200"> <div class="rounded-lg border border-amber-200 bg-amber-50 px-4 py-3 text-sm text-amber-800 dark:border-amber-700 dark:bg-amber-900/30 dark:text-amber-200">
Tokens are optional on this Pulse instance. Confirm to continue to the install commands. Tokens are optional on this Pulse instance. Confirm to generate commands without embedding a token.
</div> </div>
<button <button
type="button" type="button"
@ -499,7 +498,7 @@ export const HostAgents: Component<HostAgentsProps> = (props) => {
: 'bg-gray-900 text-white hover:bg-black dark:bg-gray-100 dark:text-gray-900 dark:hover:bg-white' : 'bg-gray-900 text-white hover:bg-black dark:bg-gray-100 dark:text-gray-900 dark:hover:bg-white'
}`} }`}
> >
{stepTwoComplete() ? 'Confirmed' : 'Confirm and continue'} {stepTwoComplete() ? 'No token confirmed' : 'Confirm without token'}
</button> </button>
</div> </div>
</Show> </Show>