From 6ae187c954dd15851d7dd2bbca4444f2eadce58f Mon Sep 17 00:00:00 2001
From: rcourtman <courtmanr@gmail.com>
Date: Mon, 1 Dec 2025 15:20:11 +0000
Subject: [PATCH] test: Add comprehensive tests for hasExpired function

Cover all branches: nil ExpiresAt, future expiry, past expiry, and exact
expiry time edge case. Coverage improved from 66.7% to 100%.
---
 internal/monitoring/docker_commands_test.go | 53 +++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/internal/monitoring/docker_commands_test.go b/internal/monitoring/docker_commands_test.go
index fd8c4d1..533bb0b 100644
--- a/internal/monitoring/docker_commands_test.go
+++ b/internal/monitoring/docker_commands_test.go
@@ -234,6 +234,59 @@ func TestAllowDockerHostReenrollNoopWhenHostNotBlocked(t *testing.T) {
 	}
 }
 
+func TestDockerCommandHasExpired(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		name      string
+		expiresAt *time.Time
+		checkTime time.Time
+		want      bool
+	}{
+		{
+			name:      "nil ExpiresAt returns false",
+			expiresAt: nil,
+			checkTime: time.Now(),
+			want:      false,
+		},
+		{
+			name:      "future expiry returns false",
+			expiresAt: func() *time.Time { t := time.Now().Add(time.Hour); return &t }(),
+			checkTime: time.Now(),
+			want:      false,
+		},
+		{
+			name:      "past expiry returns true",
+			expiresAt: func() *time.Time { t := time.Now().Add(-time.Hour); return &t }(),
+			checkTime: time.Now(),
+			want:      true,
+		},
+		{
+			name:      "exact expiry time returns false",
+			expiresAt: func() *time.Time { t := time.Date(2025, 1, 1, 12, 0, 0, 0, time.UTC); return &t }(),
+			checkTime: time.Date(2025, 1, 1, 12, 0, 0, 0, time.UTC),
+			want:      false, // checkTime.After(expiresAt) is false when equal
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
+			cmd := &dockerHostCommand{
+				status: models.DockerHostCommandStatus{
+					ExpiresAt: tt.expiresAt,
+				},
+			}
+
+			got := cmd.hasExpired(tt.checkTime)
+			if got != tt.want {
+				t.Errorf("hasExpired() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
+
 func TestAcknowledgeDockerCommandErrorPaths(t *testing.T) {
 	t.Parallel()