From 5f05718c3ed2c09200466290aa1389a391ebb273 Mon Sep 17 00:00:00 2001 From: rcourtman Date: Tue, 11 Nov 2025 16:09:02 +0000 Subject: [PATCH] Fix release notes backtick command substitution issue Use --notes-file instead of --notes with variable expansion to prevent bash from interpreting markdown code blocks as shell commands. Fixes the error where installation examples like: ```bash docker pull rcourtman/pulse:v4.29.0 ``` Were being executed as actual commands during release creation. Related to #671 --- .github/workflows/release.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ad58d91..5ef4293 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -220,11 +220,17 @@ jobs: # Use LLM-generated release notes NOTES="${{ steps.generate_notes.outputs.RELEASE_NOTES }}" + # Write notes to file to avoid bash interpreting backticks as commands + NOTES_FILE=$(mktemp) + echo "$NOTES" > "$NOTES_FILE" + # Create draft release with generated notes gh release create "${TAG}" \ --draft \ --title "Pulse ${TAG}" \ - --notes "$NOTES" + --notes-file "$NOTES_FILE" + + rm -f "$NOTES_FILE" echo "release_url=$(gh release view ${TAG} --json url -q .url)" >> $GITHUB_OUTPUT echo "tag=${TAG}" >> $GITHUB_OUTPUT