danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf: Cache err.Error() in disk monitoring error handling

Browse source 
Compute err.Error() once and reuse errStr instead of calling Error()
four times when checking disk monitoring error types.
This commit is contained in:
rcourtman 2025-12-02 15:37:48 +00:00
parent 9fc567dc2e
commit 5d2eca3660
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
internal/monitoring/monitor.go
View file

@ -4727,12 +4727,13 @@ func (m *Monitor) pollPVEInstance(ctx context.Context, instanceName string, clie
disks, err := client.GetDisks(ctx, node.Node)
if err != nil {
// Check if it's a permission error or if the endpoint doesn't exist
if strings.Contains(err.Error(), "401") || strings.Contains(err.Error(), "403") {
errStr := err.Error()
if strings.Contains(errStr, "401") || strings.Contains(errStr, "403") {
log.Warn().
Str("node", node.Node).
Err(err).
Msg("Insufficient permissions to access disk information - check API token permissions")
} else if strings.Contains(err.Error(), "404") || strings.Contains(err.Error(), "501") {
} else if strings.Contains(errStr, "404") || strings.Contains(errStr, "501") {
log.Info().
Str("node", node.Node).
Msg("Disk monitoring not available on this node (may be using non-standard storage)")